Skip to content

Conversation

@John-Paul-R
Copy link
Contributor

@John-Paul-R John-Paul-R commented Dec 1, 2025

fix(SchemaGenerator): exclude inherited properties only when base added to AllOf

resolves #3201


I've outlined the theory for this change in this comment: #3201 (comment)

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.66%. Comparing base (4ae817b) to head (ca8a636).
⚠️ Report is 12 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3692   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files         111      111           
  Lines        3858     3859    +1     
  Branches      778      778           
=======================================
+ Hits         3652     3653    +1     
  Misses        206      206           
Flag Coverage Δ
Linux 94.66% <100.00%> (+<0.01%) ⬆️
Windows 94.66% <100.00%> (+<0.01%) ⬆️
macOS 94.66% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello
Copy link
Collaborator

Could you also add a test somewhere in the existing integration test project that would produce outputs in a snapshot file please? It's much easier to verify the behaviour in those kinds of tests where the rendered OpenAPI document is visible.

@John-Paul-R
Copy link
Contributor Author

@martincostello Attempted a snapshot test, let me know if that looks as you expect!

@John-Paul-R John-Paul-R force-pushed the fix-2-level-inheritance-skip branch from 7074294 to cd12095 Compare December 3, 2025 05:51
Copy link
Collaborator

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion for another test, but otherwise seems OK to me.

…itance, which reveals a problem

fixing in next commit
@martincostello martincostello added this to the v10.0.2 milestone Dec 3, 2025
@martincostello martincostello merged commit 025ae09 into domaindrivendev:master Dec 3, 2025
18 of 19 checks passed
@martincostello
Copy link
Collaborator

Thanks!

This was referenced Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Behavior change with UseOneOfForPolymorphism and abstract classes from version 7.0.0 and version 7.2.0

2 participants