Skip to content

fix(SchemaGenerator): exclude inherited properties only when base add… #3692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martincostello merged 7 commits into from
Dec 3, 2025
Merged

fix(SchemaGenerator): exclude inherited properties only when base add… #3692

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a1cc783
fix(SchemaGenerator): exclude inherited properties only when base add…
John-Paul-R Dec 1, 2025
13bd690
test: add regression test ...
John-Paul-R Dec 1, 2025
cd12095
attempt a snapshot test
John-Paul-R Dec 3, 2025
77cef83
fix my dotnet9 setup and add relevant snapshot
John-Paul-R Dec 3, 2025
6a8d28d
test: add FakeControllerWithInheritance + add a 'response' test
John-Paul-R Dec 3, 2025
741f08a
test: add B to test, also add GenerateSchema_PreservesMultiLevelInher…
John-Paul-R Dec 3, 2025
ca8a636
fix: handle multi-level inheritance where all levels of the hierarchy…
John-Paul-R Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(SchemaGenerator): exclude inherited properties only when base add… 
…ed to AllOf
  • Loading branch information
@John-Paul-R
John-Paul-R committed Dec 1, 2025
commit a1cc783dee47bab55a241c29b3d913fc256d5cb1
2 changes: 1 addition & 1 deletion src/Swashbuckle.AspNetCore.SwaggerGen/SchemaGenerator/SchemaGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ private OpenApiSchema CreateObjectSchema(DataContract dataContract, SchemaReposi
}

applicableDataProperties = applicableDataProperties
.Where(dataProperty => dataProperty.MemberInfo.DeclaringType == dataContract.UnderlyingType);
.Where(dataProperty => dataProperty.MemberInfo.DeclaringType != baseTypeDataContract.UnderlyingType);
}

if (IsBaseTypeWithKnownTypesDefined(dataContract, out var knownTypesDataContracts))
Expand Down