Update SourceIndexPackageVersion

[wtgodbe]

Dupe of dotnet/aspnetcore#51715. Related: dotnet/source-indexer#120

[wtgodbe]

Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Build.Framework, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.

In the SourceIndex job. @garath @riarenas any ideas?

[riarenas]

No ideas, as I'm not familiar with the source index code at all.

Can you remind me what is driving the need for a new binlog version, and therefore this chain of changes?

[wtgodbe]

MSBuild.StructuredLogViewer updates sometimes break source-index:

Unhandled exception. System.NotSupportedException: Unsupported log file format. Latest supported version is 16, the log file has version 17.

We've been seeing this in every Source-Index job in aspnetcore for the past few days, which motivated dotnet/source-indexer#120. For now we've disabled source-index in aspnetcore

[riarenas]

Do you know what caused the aspnetcore build to try to use newer binlog versions?

[wtgodbe]

Do you know what caused the aspnetcore build to try to use newer binlog versions?

I think msbuild got updated to generate the new binlog versions, so the build machines we run on must have gotten updated to use that new version. We haven't changed anything with regards to binlog generation

[wtgodbe]

@dotnet/dnceng who else might know about source-index? We've had to disable it in aspnetcore because of this error

[markwilkie]

Ownership of this was transferred to @SteveMCarroll a bit ago. I'm not sure who he has to work on it right now, but off course, we're happy to assist whoever that is where we can.

cc/ @garath @shawnro

[ViktorHofer]

I think msbuild got updated to generate the new binlog versions, so the build machines we run on must have gotten updated to use that new version. We haven't changed anything with regards to binlog generation

Correct. We need to keep the StructuredLogViewer nuget package reference up-to-date so that it can handle newer binlog versions. MSBuild from time to time revs the binlog version when they add new stuff to the format.

[ViktorHofer]

This is likely required before updating Arcade to a .NET 9 SDK. @wtgodbe what's the status on this? Is there anything left?

[wtgodbe]

I don't know what needs to be done here, I tried doing a simple update but it failed - I don't own SourceIndex, I was hoping someone with more experience with the tool could handle the update.

[ViktorHofer]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[mmitche]

Loading 15.1 MSBuild...odd...okay

[ViktorHofer]

Should we also update the .NET SDK to 8?

arcade/eng/common/templates/job/source-index-stage1.yml

Lines 42 to 48 in 1f6c5ac

	- task: UseDotNet@2
	displayName: Use .NET Core SDK 6
	inputs:
	packageType: sdk
	version: 6.0.x
	installationPath: $(Agent.TempDirectory)/dotnet
	workingDirectory: $(Agent.TempDirectory)

[wtgodbe]

When I was doing the update in source-indexer, I had to update some MSBuild deps to fix transitive dependency errors in the official build - maybe related? https://github.com/dotnet/source-indexer/pull/121/files

[ViktorHofer]

Yeah, 17.5 of msbuild packages should require that version of msbuild. So we probably need to update the SDK.

[ViktorHofer]

I added a rollforward switch to the two global tools for now but we ideally should just make them target net8.0 instead.

[ViktorHofer]

@mmitche now I'm unsure if the 1es-windows-2022-open images already have VS 17.8 installed. Could we use a different pool, i.e. the VS preview pool?

[mmitche]

Our stock 2022 pool has 17.8. Let me switch to that.

[ViktorHofer]

Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Build.Framework, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.

Hmm I'm out of ideas unless trying to repro this locally. cc @rainersigwald in case you understand why the msbuild assembly isn't found / loaded.

[mmitche]

Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Build.Framework, Version=15.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.

Hmm I'm out of ideas unless trying to repro this locally. cc @rainersigwald in case you understand why the msbuild assembly isn't found / loaded.

And why 15.1.0.0?...that such an old number

[rainersigwald]

Hmm I'm out of ideas unless trying to repro this locally. cc @rainersigwald in case you understand why the msbuild assembly isn't found / loaded.

And why 15.1.0.0?...that such an old number

that's our current version, frozen in amber at the point we went open-source :-/

[mmitche]

Hmm I'm out of ideas unless trying to repro this locally. cc @rainersigwald in case you understand why the msbuild assembly isn't found / loaded.

And why 15.1.0.0?...that such an old number

that's our current version, frozen in amber at the point we went open-source :-/

[rainersigwald]

I don't know what's going on here, though. I'll plan to take a look tomorrow morning.

[akoeplinger]

I root caused the failure and will have a PR shortly for dotnet/source-indexer

[akoeplinger]

dotnet/source-indexer#123

[ViktorHofer]

@akoeplinger thank you so much!