Port "ignore nonexistent queue" functionality to release/5.0 #8153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [release/5.0] Update the SDK to 5.0 RC2 We want to update the SDK from 5.0 RC1 to RC2. * Add the 5.0 branch to the pipeline yml
This reverts commit 4eff4ec.
…otnet#6467) This removes the Validation stage if both of these conditions are false: - There's an inline v2 publishing (for checking whether a channel exists) - Any post-build validation is enabled Every job dependency transition has a pretty decent cost. The stage typically takes a minute or so, and also requires getting a machine, etc. This adds up
…n.txt" file (dotnet#6051)" (dotnet#6492) This reverts commit 88ce535 except for spelling errors.
[release/5.0] Update dependencies from dotnet/arcade - re-enable signing validation
…130.4 (dotnet#6681) [release/5.0] Update dependencies from dotnet/arcade
…221.10 (dotnet#6788) [release/5.0] Update dependencies from dotnet/arcade
…113.3 (dotnet#6797) [release/5.0] Update dependencies from dotnet/arcade
…dotnet#6877) * removed load of guardian configuration from sdl-tool-cfg * clean up of commented block of code (cherry picked from commit 0e5bd28)
Co-authored-by: Matt Mitchell <[email protected]>
* add vs16.10 and vs.16.9 channels
…212.3 (dotnet#6954) [release/5.0] Update dependencies from dotnet/arcade
react to branch rename
…309.2 (dotnet#7077) [release/5.0] Update dependencies from dotnet/arcade
…309.7 (dotnet#7085) [release/5.0] Update dependencies from dotnet/arcade
## Description This change is part of moving servicing jobs to COGS subscription: https://github.com/dotnet/core-eng/issues/11639. We need to include `System.PullRequest.TargetBranch` pipeline variable in Helix job properties to be able to redirect PR test jobs to servicing subscription. Currently Helix API has no way to tell if the PR was created for `main` or `release/*` branch. I also added other properties that are send in `main` for consistency. Related issue: dotnet#7074 ## Customer Impact There is no customer impact. Only effect is that additional properties will be attached to Helix job. ## Regression No ## Risk The risk of this change is very low. Change is very small and the same code already runs on main. ## Workarounds There is no workaround available. Without this change we won't be able to redirect servicing PR test jobs to COGS subscription.
…310.3 (dotnet#7230) [release/5.0] Update dependencies from dotnet/arcade
…ion (addresses dotnet#7255, msbuild needs release/5.0) (dotnet#7306)
Update to pick up fix for dotnet/core-eng#12911
…otnet#7382) Cherry-pick of b61eaae Co-authored-by: Hao Kung <[email protected]>
…512.2 (dotnet#7491) [release/5.0] Update dependencies from dotnet/arcade
- cherry-pick of a5dbede / dotnet#7531
- use `Get-Member` instead of assuming `$null` property value - fixes build break I caused in 0214a32
…628.3 (dotnet#7597) [release/5.0] Update dependencies from dotnet/arcade
…net#7650) Co-authored-by: Matt Thalman <[email protected]>
* Add `global:` prefix to `LASTEXITCODE = 0` * Handle git commit exit code 1 when there is nothing staged * Pass-through error code from child scripts in execute-all-sdl-tools.ps1
* Publish to multiple channels - Part 2 (dotnet#6754) * Publish to multiple channels * Update tag references to dotnet-buildtools/prereqs (dotnet#7608) Co-authored-by: Epsitha Ananth <[email protected]> Co-authored-by: Matt Thalman <[email protected]>
…727.1 (dotnet#7703) [release/5.0] Update dependencies from dotnet/arcade
…809.4 (dotnet#7735) [release/5.0] Update dependencies from dotnet/arcade
…827.7 (dotnet#7858) [release/5.0] Update dependencies from dotnet/arcade
* update to latest released SDK * bump again to latest released
…921.4 (dotnet#7938) [release/5.0] Update dependencies from dotnet/arcade
Cherry-pick of e32ba79 * Update the version of Microsoft.Data.OData * Update Microsoft.Data.Services.Client as well Co-authored-by: Michelle McDaniel <[email protected]>
…s.Templating (dotnet#7502) * Migrate GenerateFileFromTemplate to Microsoft.DotNet.Build.Tasks.Templating (dotnet#7403) Co-authored-by: Viktor Hofer <[email protected]> Co-authored-by: Doug Bunting <[email protected]> Co-authored-by: Rainer Sigwald <[email protected]> * 5.0 fixes * TFM update Co-authored-by: John Luo <[email protected]> Co-authored-by: Viktor Hofer <[email protected]> Co-authored-by: Doug Bunting <[email protected]> Co-authored-by: Rainer Sigwald <[email protected]>
…009.1 (dotnet#8021) [release/5.0] Update dependencies from dotnet/arcade
Allow for a product to control the scheduling of Major Upgrade. We'll do this in the host installer to make upgrade late and preserve PATH.
…013.1 (dotnet#8036) [release/5.0] Update dependencies from dotnet/arcade
…102.7 (dotnet#8137) [release/5.0] Update dependencies from dotnet/arcade
…onally ignore when a queue does not exist. Port of dotnet#8069 (bbb4187)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To double check:
Description
Context: https://github.com/dotnet/core-eng/issues/14572
Port of #8069 (bbb4187). Allows users who want to to ignore non-existent Helix queues, so we don't have to keep every queue that we've ever had in existence in our yaml files forever.
Customer Impact
This change allows customers to decide whether their build should break (and thus require attention) when sending to and end-of-life-d queue, or just print a warning.
Without this change, any old queue that has been removed (e.g. OSX.1012.Amd64) will cause failure once the changes to do this are merged.
Regression
No
Risk
Low; only two queues we'd remove (osx.1012.amd64, redhat.6.amd64) have been used in the past 30 days, from 3.1 release branches, and these can be left alone until addressed.
Workarounds
User will have to work around this by removing dead queues manually without this setting available in the Arcade SDK.