[release/13.0] Fix DockerComposeEnvironment duplicating image names in .env file #12539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: davidfowl <[email protected]>
Co-authored-by: davidfowl <[email protected]>
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
Contributor
Author
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12539Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12539" |
captainsafia
approved these changes
Nov 1, 2025
davidfowl
approved these changes
Nov 1, 2025
davidfowl
reviewed
Nov 1, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12310 to release/13.0
/cc @captainsafia @copilot
Customer Impact
This is a regression from the last release. When updating environment variables in .env files with
onlyIfMissing: false, duplicate key entries are generated in the file instead of updating the existing key. This causes invalid .env files with multiple definitions of the same variable and breaks Docker container configuration.Testing
Unit tests and manual validation.
Risk
Low. The fix refactors key parsing into a reusable
TryParseKeymethod and adds logic to update existing key values in-place whenonlyIfMissing: false. The change is localized to theEnvFile.Addmethod and maintains backward compatibility for theonlyIfMissing: truecase.Regression?
Yes - this fixes a regression where duplicate keys were created in .env files.