Skip to content

[release/13.0] Fix DockerComposeEnvironment duplicating image names in .env file #12539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidfowl merged 4 commits into from
Nov 1, 2025
Merged

[release/13.0] Fix DockerComposeEnvironment duplicating image names in .env file #12539

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
230e020
Initial plan
Copilot Oct 23, 2025
c77f01f
Fix DockerComposeEnvironment image name duplication in EnvFile
Copilot Oct 23, 2025
9bd4a3a
Refactor EnvFile to extract duplicate parsing logic into helper method
Copilot Oct 30, 2025
cd70731
Update src/Aspire.Hosting.Docker/EnvFile.cs
davidfowl Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update src/Aspire.Hosting.Docker/EnvFile.cs
  • Loading branch information
@davidfowl
davidfowl authored Nov 1, 2025
commit cd707312c714b6dbdec646611b689d188531ec5f
2 changes: 1 addition & 1 deletion src/Aspire.Hosting.Docker/EnvFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public void Add(string key, string? value, string? comment, bool onlyIfMissing =
return;
}

// Update the existing key's value
// Update the existing key's value.
for (int i = 0; i < _lines.Count; i++)
{
if (TryParseKey(_lines[i], out var lineKey) && lineKey == key)
Expand Down