[release/13.0] Fix .env files being overwritten by Docker Compose publisher #12703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SaveKeysOnly is called, it now checks if keys already exist on disk with non-empty values and preserves those values instead of overwriting them. This ensures that user modifications to .env files are not lost during subsequent publish operations. Co-authored-by: captainsafia <[email protected]>
- Store path on Load as private field - Remove path parameter from Save/SaveKeysOnly methods - Use existing values in Entries instead of reloading from disk - Change _entries to internal Entries property - Update PrepareAsync to initialize its own EnvFile - Update all test usages to call Save() without path parameter Co-authored-by: captainsafia <[email protected]>
- Add ILogger parameter to EnvFile.Load() and constructor - Log at Information level when saving with values overwrites existing file - Fix trailing whitespace on line 134 - Update callers to pass logger from context - All tests pass Co-authored-by: captainsafia <[email protected]>
- Add EnvFile.Create() method to create new env file without loading existing content - Update PrepareAsync to use Create() instead of Load() to avoid loading old entries - Add PrepareStep_OverwritesExistingEnvFileAndLogsWarning test - Add PrepareStep_OverwritesExistingEnvFileWithCustomEnvironmentName test - Both tests verify file is overwritten and log message is emitted - All 60 tests pass Co-authored-by: captainsafia <[email protected]>
- Remove SharedEnvFile property from DockerComposeEnvironmentResource - Remove SharedEnvFile usage from DockerComposePublishingContext - EnvFile is now loaded fresh on each publish operation - All 60 tests pass Co-authored-by: captainsafia <[email protected]>
dotnet-policy-service
bot
added
Re-opened Github-Action PR
and removed
Closed Github-Action PR
labels
Contributor
Author
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12703Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12703" |
eerhardt
approved these changes
Nov 5, 2025
davidfowl
approved these changes
Nov 5, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #12656 to release/13.0
/cc @captainsafia @copilot
Customer Impact
.envvalues during publish; now only adds missing keys and preserves existing values..env.{EnvironmentName}file (e.g.,.env.Production/.env.Staging) and logs that it’s being overwritten.Testing
Risk
Regression?