Skip to content

Makes VolumeNameGenerator public #6531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danmoseley merged 9 commits into from
Oct 29, 2024
Merged

Makes VolumeNameGenerator public #6531

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c060416
-Makes VolumeNameGenerator public
los93sol Oct 28, 2024
d53789b
Update src/Aspire.Hosting/Utils/VolumeNameGenerator.cs
los93sol Oct 28, 2024
7e21b6f
Take @danmosely suggestion to change the exception message
los93sol Oct 28, 2024
050c070
Renames VolumeNameGenerator.CreateVolumeName to Generate
los93sol Oct 29, 2024
7c679ec
-Mark VolumeNameGenerator.Sanitize as internal
los93sol Oct 29, 2024
42ad133
Pretty sure that should be all of it
los93sol Oct 29, 2024
22489be
Oops
los93sol Oct 29, 2024
2445ce1
Update src/Aspire.Hosting/Utils/VolumeNameGenerator.cs
los93sol Oct 29, 2024
68b0959
Drops code doc of Sanitize since it's not public
los93sol Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Oops
  • Loading branch information
@los93sol
los93sol committed Oct 29, 2024
commit 22489be62b3cd1c58849fe308949a27b153907ca
2 changes: 1 addition & 1 deletion src/Aspire.Hosting/Utils/VolumeNameGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public static string Generate<T>(IResourceBuilder<T> builder, string suffix) whe
{
if (!HasOnlyValidChars(suffix))
{
throw new ArgumentException($"The suffix '{suffix}' contains invalid characters. Only [a-zA-Z0-9_.-] are allowed.", nameof(suffix));
throw new ArgumentException($"The suffix '{suffix}' contains invalid characters. It must match [a-zA-Z0-9][a-zA-Z0-9_.-]*.", nameof(suffix));
}

// Create volume name like "{Sanitize(appname).Lower()}-{sha256.Lower()}-postgres-data"
Expand Down