-
Notifications
You must be signed in to change notification settings - Fork 761
Makes VolumeNameGenerator public #6531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c060416
-Makes VolumeNameGenerator public
los93sol d53789b
Update src/Aspire.Hosting/Utils/VolumeNameGenerator.cs
los93sol 7e21b6f
Take @danmosely suggestion to change the exception message
los93sol 050c070
Renames VolumeNameGenerator.CreateVolumeName to Generate
los93sol 7c679ec
-Mark VolumeNameGenerator.Sanitize as internal
los93sol 42ad133
Pretty sure that should be all of it
los93sol 22489be
Oops
los93sol 2445ce1
Update src/Aspire.Hosting/Utils/VolumeNameGenerator.cs
los93sol 68b0959
Drops code doc of Sanitize since it's not public
los93sol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Take @danmosely suggestion to change the exception message
- Loading branch information
commit 7e21b6fd00cd50ed2bc90f7306fdcf2a84cd9b7d
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.