Analyzers

.editorconfig

@@ -178,6 +178,9 @@ dotnet_diagnostic.CA1846.severity = warning
 # CA1847: Use string.Contains(char) instead of string.Contains(string) with single characters
 dotnet_diagnostic.CA1847.severity = warning
 
+# CA1852: Seal internal types
+dotnet_diagnostic.CA1852.severity = warning
+
 # CA2007: Consider calling ConfigureAwait on the awaited task
 dotnet_diagnostic.CA2007.severity = warning
 
@@ -302,6 +305,8 @@ dotnet_diagnostic.CA1845.severity = suggestion
 dotnet_diagnostic.CA1846.severity = suggestion
 # CA1847: Use string.Contains(char) instead of string.Contains(string) with single characters
 dotnet_diagnostic.CA1847.severity = suggestion
+# CA1852: Seal internal types
+dotnet_diagnostic.CA1852.severity = suggestion
 # CA2007: Consider calling ConfigureAwait on the awaited task
 dotnet_diagnostic.CA2007.severity = suggestion
 # CA2008: Do not create tasks without passing a TaskScheduler

src/Analyzers/Analyzers/src/BuildServiceProviderAnalyzer.cs

@@ -7,7 +7,7 @@
 
 namespace Microsoft.AspNetCore.Analyzers;
 
-internal class BuildServiceProviderAnalyzer
+internal sealed class BuildServiceProviderAnalyzer
 {
     private readonly StartupAnalysis _context;
 

src/Analyzers/Analyzers/src/ConfigureMethodVisitor.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.AspNetCore.Analyzers;
 
-internal class ConfigureMethodVisitor : SymbolVisitor
+internal sealed class ConfigureMethodVisitor : SymbolVisitor
 {
     public static List<IMethodSymbol> FindConfigureMethods(StartupSymbols symbols, IAssemblySymbol assembly)
     {

src/Analyzers/Analyzers/src/MiddlewareAnalysis.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.AspNetCore.Analyzers;
 
-internal class MiddlewareAnalysis
+internal sealed class MiddlewareAnalysis
 {
     public MiddlewareAnalysis(IMethodSymbol configureMethod, ImmutableArray<MiddlewareItem> middleware)
     {

src/Analyzers/Analyzers/src/MiddlewareAnalyzer.cs

@@ -8,7 +8,7 @@
 
 namespace Microsoft.AspNetCore.Analyzers;
 
-internal class MiddlewareAnalyzer
+internal sealed class MiddlewareAnalyzer
 {
     private readonly StartupAnalysisBuilder _context;
 

src/Analyzers/Analyzers/src/MiddlewareItem.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.AspNetCore.Analyzers;
 
-internal class MiddlewareItem
+internal sealed class MiddlewareItem
 {
     public MiddlewareItem(IInvocationOperation operation)
     {

src/Analyzers/Analyzers/src/OptionsAnalysis.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.AspNetCore.Analyzers;
 
-internal class OptionsAnalysis
+internal sealed class OptionsAnalysis
 {
     public OptionsAnalysis(IMethodSymbol configureServicesMethod, ImmutableArray<OptionsItem> options)
     {

src/Analyzers/Analyzers/src/OptionsAnalyzer.cs

@@ -9,7 +9,7 @@
 
 namespace Microsoft.AspNetCore.Analyzers;
 
-internal class OptionsAnalyzer
+internal sealed class OptionsAnalyzer
 {
     private readonly StartupAnalysisBuilder _context;
 

src/Analyzers/Analyzers/src/OptionsItem.cs

@@ -5,7 +5,7 @@
 
 namespace Microsoft.AspNetCore.Analyzers;
 
-internal class OptionsItem
+internal sealed class OptionsItem
 {
     public OptionsItem(IPropertySymbol property, object constantValue)
     {

src/Analyzers/Analyzers/src/ServicesAnalysis.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.AspNetCore.Analyzers;
 
-internal class ServicesAnalysis
+internal sealed class ServicesAnalysis
 {
     public ServicesAnalysis(IMethodSymbol configureServicesMethod, ImmutableArray<ServicesItem> services)
     {

src/Analyzers/Analyzers/src/ServicesAnalyzer.cs

@@ -8,7 +8,7 @@
 
 namespace Microsoft.AspNetCore.Analyzers;
 
-internal class ServicesAnalyzer
+internal sealed class ServicesAnalyzer
 {
     private readonly StartupAnalysisBuilder _context;
 

src/Analyzers/Analyzers/src/ServicesItem.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.AspNetCore.Analyzers;
 
-internal class ServicesItem
+internal sealed class ServicesItem
 {
     public ServicesItem(IInvocationOperation operation)
     {

src/Analyzers/Analyzers/src/StartupAnalysis.cs

@@ -6,7 +6,7 @@
 
 namespace Microsoft.AspNetCore.Analyzers;
 
-internal class StartupAnalysis
+internal sealed class StartupAnalysis
 {
     private readonly ImmutableDictionary<INamedTypeSymbol, ImmutableArray<object>> _analysesByType;
 

src/Analyzers/Analyzers/src/StartupAnalysisBuilder.cs

@@ -7,7 +7,7 @@
 
 namespace Microsoft.AspNetCore.Analyzers;
 
-internal class StartupAnalysisBuilder
+internal sealed class StartupAnalysisBuilder
 {
     private readonly Dictionary<INamedTypeSymbol, List<object>> _analysesByType;
     private readonly StartupAnalyzer _analyzer;

src/Analyzers/Analyzers/src/StartupSymbols.cs

@@ -5,7 +5,7 @@
 
 namespace Microsoft.AspNetCore.Analyzers;
 
-internal class StartupSymbols
+internal sealed class StartupSymbols
 {
     public StartupSymbols(Compilation compilation)
     {

src/Analyzers/Analyzers/src/UseAuthorizationAnalyzer.cs

@@ -8,7 +8,7 @@
 
 namespace Microsoft.AspNetCore.Analyzers;
 
-internal class UseAuthorizationAnalyzer
+internal sealed class UseAuthorizationAnalyzer
 {
     private readonly StartupAnalysis _context;
 

src/Analyzers/Analyzers/src/UseMvcAnalyzer.cs

@@ -7,7 +7,7 @@
 
 namespace Microsoft.AspNetCore.Analyzers;
 
-internal class UseMvcAnalyzer
+internal sealed class UseMvcAnalyzer
 {
     private readonly StartupAnalysis _context;
 

src/Analyzers/Microsoft.AspNetCore.Analyzer.Testing/src/Assert.cs

@@ -38,7 +38,7 @@ public static void DiagnosticLocation(DiagnosticLocation expected, Location actu
         }
     }
 
-    private class DiagnosticLocationAssertException : EqualException
+    private sealed class DiagnosticLocationAssertException : EqualException
     {
         public DiagnosticLocationAssertException(
             DiagnosticLocation expected,

src/Analyzers/Microsoft.AspNetCore.Analyzer.Testing/src/DiagnosticVerifier.cs

@@ -185,7 +185,7 @@ protected Project CreateProject(params string[] sources)
     }
 
     // Required to resolve compilation assemblies inside unit tests
-    private class AppLocalResolver : ICompilationAssemblyResolver
+    private sealed class AppLocalResolver : ICompilationAssemblyResolver
     {
         public bool TryResolveAssemblyPaths(CompilationLibrary library, List<string> assemblies)
         {