Hosting

dotnet · BrennanConroy · May 5, 2022 · Apr 30, 2022 · Apr 30, 2022 · Apr 30, 2022
commit 6f623a54a9644246cdb5cd28865386b2f55f25c3
@@ -5,7 +5,7 @@
 
 namespace Microsoft.AspNetCore.Hosting;
 #pragma warning disable CS0618 // Type or member is obsolete
-internal class GenericWebHostApplicationLifetime : IApplicationLifetime
+internal sealed class GenericWebHostApplicationLifetime : IApplicationLifetime
 #pragma warning restore CS0618 // Type or member is obsolete
 {
     private readonly IHostApplicationLifetime _applicationLifetime;

@@ -433,7 +433,7 @@ public IWebHostBuilder UseSetting(string key, string? value)
     }
 
     // This exists just so that we can use ActivatorUtilities.CreateInstance on the Startup class
-    private class HostServiceProvider : IServiceProvider
+    private sealed class HostServiceProvider : IServiceProvider
     {
         private readonly WebHostBuilderContext _context;
 

@@ -5,7 +5,7 @@
 
 namespace Microsoft.AspNetCore.Hosting;
 
-internal class GenericWebHostServiceOptions
+internal sealed class GenericWebHostServiceOptions
 {
     public Action<IApplicationBuilder>? ConfigureApplication { get; set; }
 

@@ -10,7 +10,7 @@ namespace Microsoft.AspNetCore.Hosting;
 /// Allows consumers to perform cleanup during a graceful shutdown.
 /// </summary>
 #pragma warning disable CS0618 // Type or member is obsolete
-internal class ApplicationLifetime : IApplicationLifetime, Extensions.Hosting.IApplicationLifetime, IHostApplicationLifetime
+internal sealed class ApplicationLifetime : IApplicationLifetime, Extensions.Hosting.IApplicationLifetime, IHostApplicationLifetime
 #pragma warning restore CS0618 // Type or member is obsolete
 {
     private readonly CancellationTokenSource _startedSource = new CancellationTokenSource();

@@ -8,7 +8,7 @@
 
 namespace Microsoft.AspNetCore.Hosting;
 
-internal class ConfigureBuilder
+internal sealed class ConfigureBuilder
 {
     public ConfigureBuilder(MethodInfo configure)
     {

@@ -6,7 +6,7 @@
 
 namespace Microsoft.AspNetCore.Hosting;
 
-internal class ConfigureContainerBuilder
+internal sealed class ConfigureContainerBuilder
 {
     public ConfigureContainerBuilder(MethodInfo? configureContainerMethod)
     {

@@ -7,7 +7,7 @@
 
 namespace Microsoft.AspNetCore.Hosting;
 
-internal class ConfigureServicesBuilder
+internal sealed class ConfigureServicesBuilder
 {
     public ConfigureServicesBuilder(MethodInfo? configureServices)
     {

@@ -6,7 +6,7 @@
 
 namespace Microsoft.AspNetCore.Hosting;
 
-internal class HostedServiceExecutor
+internal sealed class HostedServiceExecutor
 {
     private readonly IEnumerable<IHostedService> _services;
     private readonly ILogger<HostedServiceExecutor> _logger;

@@ -10,7 +10,7 @@
 
 namespace Microsoft.AspNetCore.Hosting;
 
-internal class HostingApplication : IHttpApplication<HostingApplication.Context>
+internal sealed class HostingApplication : IHttpApplication<HostingApplication.Context>
 {
     private readonly RequestDelegate _application;
     private readonly IHttpContextFactory? _httpContextFactory;
@@ -116,7 +116,7 @@ public void DisposeContext(Context context, Exception? exception)
         context.Reset();
     }
 
-    internal class Context
+    internal sealed class Context
     {
         public HttpContext? HttpContext { get; set; }
         public IDisposable? Scope { get; set; }

@@ -12,7 +12,7 @@
 
 namespace Microsoft.AspNetCore.Hosting;
 
-internal class HostingApplicationDiagnostics
+internal sealed class HostingApplicationDiagnostics
 {
     private static readonly double TimestampToTicks = TimeSpan.TicksPerSecond / (double)Stopwatch.Frequency;
 

@@ -5,7 +5,7 @@
 
 namespace Microsoft.AspNetCore.Hosting;
 #pragma warning disable CS0618 // Type or member is obsolete
-internal class HostingEnvironment : IHostingEnvironment, Extensions.Hosting.IHostingEnvironment, IWebHostEnvironment
+internal sealed class HostingEnvironment : IHostingEnvironment, Extensions.Hosting.IHostingEnvironment, IWebHostEnvironment
 #pragma warning restore CS0618 // Type or member is obsolete
 {
     public string EnvironmentName { get; set; } = Extensions.Hosting.Environments.Production;

@@ -116,7 +116,7 @@ internal static void Initialize(
         }
 
         hostingEnvironment.EnvironmentName =
-            baseEnvironment?.EnvironmentName ?? 
+            baseEnvironment?.EnvironmentName ??
             options.Environment ??
             hostingEnvironment.EnvironmentName;
     }

@@ -9,7 +9,7 @@ namespace Microsoft.AspNetCore.Hosting;
 
 using static HostingRequestStartingLog;
 
-internal class HostingRequestFinishedLog : IReadOnlyList<KeyValuePair<string, object?>>
+internal sealed class HostingRequestFinishedLog : IReadOnlyList<KeyValuePair<string, object?>>
 {
     internal static readonly Func<object, Exception?, string> Callback = (state, exception) => ((HostingRequestFinishedLog)state).ToString();
 

@@ -7,7 +7,7 @@
 
 namespace Microsoft.AspNetCore.Hosting;
 
-internal class HostingRequestStartingLog : IReadOnlyList<KeyValuePair<string, object?>>
+internal sealed class HostingRequestStartingLog : IReadOnlyList<KeyValuePair<string, object?>>
 {
     private const string LogPreamble = "Request starting ";
     private const string EmptyEntry = "-";

@@ -10,7 +10,7 @@
 
 namespace Microsoft.AspNetCore.Hosting;
 
-internal class StartupLoader
+internal sealed class StartupLoader
 {
     // Creates an <see cref="StartupMethods"/> instance with the actions to run for configuring the application services and the
     // request pipeline of the application.
@@ -68,7 +68,7 @@ private abstract class ConfigureServicesDelegateBuilder
         public abstract Func<IServiceCollection, IServiceProvider> Build();
     }
 
-    private class ConfigureServicesDelegateBuilder<TContainerBuilder> : ConfigureServicesDelegateBuilder where TContainerBuilder : notnull
+    private sealed class ConfigureServicesDelegateBuilder<TContainerBuilder> : ConfigureServicesDelegateBuilder where TContainerBuilder : notnull
     {
         public ConfigureServicesDelegateBuilder(
             IServiceProvider hostingServiceProvider,

@@ -7,7 +7,7 @@
 
 namespace Microsoft.AspNetCore.Hosting;
 
-internal class StartupMethods
+internal sealed class StartupMethods
 {
     public StartupMethods(object? instance, Action<IApplicationBuilder> configure, Func<IServiceCollection, IServiceProvider> configureServices)
     {

@@ -3,7 +3,7 @@
 
 namespace Microsoft.AspNetCore.Hosting;
 
-internal class WebHostLifetime : IDisposable
+internal sealed class WebHostLifetime : IDisposable
 {
     private readonly CancellationTokenSource _cts;
     private readonly ManualResetEventSlim _resetEvent;

@@ -9,7 +9,7 @@
 
 namespace Microsoft.AspNetCore.Hosting;
 
-internal class WebHostOptions
+internal sealed class WebHostOptions
 {
     public WebHostOptions(IConfiguration primaryConfiguration, IConfiguration? fallbackConfiguration = null, IHostEnvironment? environment = null)
     {

@@ -3,7 +3,7 @@
 
 namespace Microsoft.AspNetCore.Hosting;
 
-internal class WebHostUtilities
+internal sealed class WebHostUtilities
 {
     public static bool ParseBool(string? value)
     {

@@ -8,7 +8,7 @@
 
 namespace Microsoft.AspNetCore.Hosting;
 
-internal class ConventionBasedStartup : IStartup
+internal sealed class ConventionBasedStartup : IStartup
 {
     private readonly StartupMethods _methods;
 

@@ -1,12 +1,12 @@
-// Licensed to the .NET Foundation under one or more agreements.
+// Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.
 
 using System.Net.Http;
 using Microsoft.Extensions.Logging;
 
 namespace Microsoft.AspNetCore.Server.IntegrationTesting;
 
-internal class LoggingHandler : DelegatingHandler
+internal sealed class LoggingHandler : DelegatingHandler
 {
     private readonly ILogger _logger;
 

@@ -337,7 +337,7 @@ private static Scripts CopyEmbeddedScriptFilesToDisk()
         return scripts;
     }
 
-    private class Scripts
+    private sealed class Scripts
     {
         public Scripts(string remotePSSessionHelper, string startServer, string stopServer)
         {

@@ -6,7 +6,7 @@
 
 namespace Microsoft.AspNetCore.Server.IntegrationTesting;
 
-internal class ProcessHelpers
+internal sealed class ProcessHelpers
 {
     public static void AddEnvironmentVariablesToProcess(ProcessStartInfo startInfo, IDictionary<string, string> environmentVariables, ILogger logger)
     {

@@ -15,7 +15,7 @@ internal abstract class ApplicationWrapper
     internal abstract void DisposeContext(object context, Exception? exception);
 }
 
-internal class ApplicationWrapper<TContext> : ApplicationWrapper, IHttpApplication<TContext> where TContext : notnull
+internal sealed class ApplicationWrapper<TContext> : ApplicationWrapper, IHttpApplication<TContext> where TContext : notnull
 {
     private readonly IHttpApplication<TContext> _application;
     private readonly Action _preProcessRequestAsync;

@@ -3,7 +3,7 @@
 
 namespace Microsoft.AspNetCore.TestHost;
 
-internal class AsyncStreamWrapper : Stream
+internal sealed class AsyncStreamWrapper : Stream
 {
     private readonly Stream _inner;
     private readonly Func<bool> _allowSynchronousIO;

@@ -7,7 +7,7 @@
 
 namespace Microsoft.AspNetCore.TestHost;
 
-internal class HttpContextBuilder : IHttpBodyControlFeature, IHttpResetFeature
+internal sealed class HttpContextBuilder : IHttpBodyControlFeature, IHttpResetFeature
 {
     private readonly ApplicationWrapper _application;
     private readonly bool _preserveExecutionContext;

@@ -5,7 +5,7 @@
 
 namespace Microsoft.AspNetCore.TestHost;
 
-internal class NoopHostLifetime : IHostLifetime
+internal sealed class NoopHostLifetime : IHostLifetime
 {
     public Task StopAsync(CancellationToken cancellationToken)
     {

@@ -5,7 +5,7 @@
 
 namespace Microsoft.AspNetCore.TestHost;
 
-internal class RequestBodyDetectionFeature : IHttpRequestBodyDetectionFeature
+internal sealed class RequestBodyDetectionFeature : IHttpRequestBodyDetectionFeature
 {
     public RequestBodyDetectionFeature(bool canHaveBody)
     {

@@ -6,7 +6,7 @@
 
 namespace Microsoft.AspNetCore.TestHost;
 
-internal class RequestFeature : IHttpRequestFeature
+internal sealed class RequestFeature : IHttpRequestFeature
 {
     public RequestFeature()
     {

@@ -5,7 +5,7 @@
 
 namespace Microsoft.AspNetCore.TestHost;
 
-internal class RequestLifetimeFeature : IHttpRequestLifetimeFeature
+internal sealed class RequestLifetimeFeature : IHttpRequestLifetimeFeature
 {
     private readonly CancellationTokenSource _cancellationTokenSource = new CancellationTokenSource();
     private readonly Action<Exception> _abort;

@@ -6,7 +6,7 @@
 
 namespace Microsoft.AspNetCore.TestHost;
 
-internal class ResponseBodyPipeWriter : PipeWriter
+internal sealed class ResponseBodyPipeWriter : PipeWriter
 {
     private readonly Func<Task> _onFirstWriteAsync;
     private readonly Pipe _pipe;

@@ -10,7 +10,7 @@ namespace Microsoft.AspNetCore.TestHost;
 /// <summary>
 /// The client's view of the response body.
 /// </summary>
-internal class ResponseBodyReaderStream : Stream
+internal sealed class ResponseBodyReaderStream : Stream
 {
     private bool _readerComplete;
     private bool _aborted;

@@ -3,7 +3,7 @@
 
 namespace Microsoft.AspNetCore.TestHost;
 
-internal class ResponseBodyWriterStream : Stream
+internal sealed class ResponseBodyWriterStream : Stream
 {
     private readonly ResponseBodyPipeWriter _responseWriter;
     private readonly Func<bool> _allowSynchronousIO;

@@ -7,7 +7,7 @@
 
 namespace Microsoft.AspNetCore.TestHost;
 
-internal class ResponseFeature : IHttpResponseFeature, IHttpResponseBodyFeature
+internal sealed class ResponseFeature : IHttpResponseFeature, IHttpResponseBodyFeature
 {
     private readonly HeaderDictionary _headers = new HeaderDictionary();
     private readonly Action<Exception> _abort;

@@ -6,7 +6,7 @@
 
 namespace Microsoft.AspNetCore.TestHost;
 
-internal class ResponseTrailersFeature : IHttpResponseTrailersFeature
+internal sealed class ResponseTrailersFeature : IHttpResponseTrailersFeature
 {
     public IHeaderDictionary Trailers { get; set; } = new HeaderDictionary();
 }