remove OnParsed: call the parsed command handler from directive handl…

…er (a dirty solution)

src/System.CommandLine.ApiCompatibility.Tests/ApiCompatibilityApprovalTests.System_CommandLine_api_is_not_changed.approved.txt

@@ -110,10 +110,8 @@ System.CommandLine
   public class Directive : Symbol
     .ctor(System.String name, System.String description = null, System.Action<System.CommandLine.Invocation.InvocationContext> syncHandler = null, System.Func<System.CommandLine.Invocation.InvocationContext,System.Threading.CancellationToken,System.Threading.Tasks.Task> asyncHandler = null)
     public System.Collections.Generic.IEnumerable<System.CommandLine.Completions.CompletionItem> GetCompletions(System.CommandLine.Completions.CompletionContext context)
-    public System.Void OnParsed(System.CommandLine.Parsing.DirectiveResult directiveResult)
   public class EnvironmentVariablesDirective : Directive
     .ctor()
-    public System.Void OnParsed(System.CommandLine.Parsing.DirectiveResult directiveResult)
   public static class Handler
     public static System.Void SetHandler(this Command command, System.Action<System.CommandLine.Invocation.InvocationContext> handle)
     public static System.Void SetHandler(this Command command, System.Action handle)

src/System.CommandLine/Directive.cs

@@ -58,15 +58,6 @@ public Directive(string name,
 
         internal ICommandHandler? Handler { get; }
 
-        /// <summary>
-        /// Method executed when given Directive is being parsed.
-        /// Useful for Directives that want to perform an action without setting the Handler for ParseResult.
-        /// </summary>
-        /// <param name="directiveResult">Parsed directive result.</param>
-        public virtual void OnParsed(DirectiveResult directiveResult)
-        {
-        }
-
         private protected override string DefaultName => throw new NotImplementedException();
 
         public override IEnumerable<CompletionItem> GetCompletions(CompletionContext context)

src/System.CommandLine/EnvironmentVariablesDirective.cs

@@ -1,4 +1,5 @@
-using System.CommandLine.Parsing;
+using System.CommandLine.Invocation;
+using System.CommandLine.Parsing;
 
 namespace System.CommandLine
 {
@@ -7,12 +8,15 @@ namespace System.CommandLine
     /// </summary>
     public sealed class EnvironmentVariablesDirective : Directive
     {
-        public EnvironmentVariablesDirective() : base("env")
+        public EnvironmentVariablesDirective() : base("env", syncHandler: SyncHandler)
         {
         }
 
-        public override void OnParsed(DirectiveResult directiveResult)
+        private static void SyncHandler(InvocationContext context)
         {
+            EnvironmentVariablesDirective symbol = (EnvironmentVariablesDirective)context.ParseResult.Symbol;
+            DirectiveResult directiveResult = context.ParseResult.FindResultFor(symbol)!;
+
             for (int i = 0; i < directiveResult.Values.Count; i++)
             {
                 string parsedValue = directiveResult.Values[i];
@@ -31,6 +35,9 @@ public override void OnParsed(DirectiveResult directiveResult)
                     }
                 }
             }
+
+            // we need a cleaner, more flexible and intuitive way of continuing the execution
+            context.ParseResult.CommandResult.Command.Handler?.Invoke(context);
         }
     }
 }

src/System.CommandLine/Parsing/ParseOperation.cs

@@ -322,7 +322,6 @@ void ParseDirective()
                     result.AddValue(withoutBrackets.Slice(indexOfColon + 1).ToString());
                 }
 
-                directive.OnParsed(result);
                 _handler = directive.Handler;
                 _symbol = directive;