Skip to content

Introduce Directive Symbol type #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 7, 2023
Merged

Introduce Directive Symbol type #2063

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0d76a52
define Directive symbols
adamsitnik Feb 21, 2023
8ce5271
tokenization
adamsitnik Feb 21, 2023
3a24a45
parsing
adamsitnik Feb 21, 2023
ac851d3
configuration
adamsitnik Feb 21, 2023
d39fe8f
making it actually work and pass most of the tests
adamsitnik Feb 21, 2023
47f9a89
handle directive specified multiple times
adamsitnik Feb 22, 2023
7127bc2
remove OnParsed: call the parsed command handler from directive handl…
adamsitnik Feb 22, 2023
da63f85
Merge remote-tracking branch 'upstream/main' into directives
adamsitnik Feb 22, 2023
96876bc
exclude private protected properties, as Relative_order_of_arguments_…
adamsitnik Feb 22, 2023
f200208
ParseDirective can print only other directives
adamsitnik Feb 22, 2023
484bc57
the reference to "this" can't be used when calling base class ctor
adamsitnik Feb 22, 2023
fc987d4
provide more flexible mechanism for directive handlers: possibility t…
adamsitnik Feb 23, 2023
ea619bf
Revert "provide more flexible mechanism for directive handlers: possi…
adamsitnik Feb 24, 2023
f37d8df
address code review feedback
adamsitnik Feb 24, 2023
8f16b15
Merge remote-tracking branch 'upstream/main' into directives
adamsitnik Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ParseDirective can print only other directives
  • Loading branch information
@adamsitnik
adamsitnik committed Feb 22, 2023
commit f200208332b96a6fc42a98cb015de1f3992ae3e5
5 changes: 1 addition & 4 deletions src/System.CommandLine/Parsing/ParseResultExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,8 @@

using System.Collections;
using System.CommandLine.Binding;
using System.CommandLine.Invocation;
using System.Linq;
using System.Text;
using System.Threading;
using System.Threading.Tasks;

namespace System.CommandLine.Parsing
{
Expand Down Expand Up @@ -62,7 +59,7 @@ private static void Diagram(

switch (symbolResult)
{
case DirectiveResult:
case DirectiveResult directiveResult when directiveResult.Directive is not ParseDirective:
break;
case ArgumentResult argumentResult:
{
Expand Down