This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Fix Abbreviated Genitive Month Names Parsing #26379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 3.0 we have fixed the formatting to use the abbreviated genitive month names when having "d" format specifier followed by "MMM". This fix is good as original formatting specs required but we needed to support the parsing when we have such genitive names.
Member
Author
|
could you please have a look? I am going to follow up to get this ported to 3.0 branch. |
Member
Author
|
Will send the test PR shortly. |
stephentoub
reviewed
Aug 26, 2019
stephentoub
reviewed
Aug 26, 2019
src/System.Private.CoreLib/shared/System/Globalization/DateTimeParse.cs
Outdated
Show resolved
Hide resolved
Member
Author
Member
Author
|
@stephentoub do you have any more comments? I am asking because I want to start creating a PR against 3.0 branch. thanks for your review. |
stephentoub
reviewed
Aug 27, 2019
src/System.Private.CoreLib/shared/System/Globalization/DateTimeFormatInfo.cs
Show resolved
Hide resolved
stephentoub
approved these changes
Aug 27, 2019
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corefx
that referenced
this pull request
Aug 27, 2019
* Fix Abbreviated Genitive Month Names Parsing In 3.0 we have fixed the formatting to use the abbreviated genitive month names when having "d" format specifier followed by "MMM". This fix is good as original formatting specs required but we needed to support the parsing when we have such genitive names. * Addressing the feedback Signed-off-by: dotnet-bot <[email protected]>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/corert
that referenced
this pull request
Aug 27, 2019
* Fix Abbreviated Genitive Month Names Parsing In 3.0 we have fixed the formatting to use the abbreviated genitive month names when having "d" format specifier followed by "MMM". This fix is good as original formatting specs required but we needed to support the parsing when we have such genitive names. * Addressing the feedback Signed-off-by: dotnet-bot <[email protected]>
tarekgh
added a commit
to dotnet/corefx
that referenced
this pull request
Aug 27, 2019
* Fix Abbreviated Genitive Month Names Parsing In 3.0 we have fixed the formatting to use the abbreviated genitive month names when having "d" format specifier followed by "MMM". This fix is good as original formatting specs required but we needed to support the parsing when we have such genitive names. * Addressing the feedback Signed-off-by: dotnet-bot <[email protected]>
jkotas
pushed a commit
to dotnet/corert
that referenced
this pull request
Aug 27, 2019
* Fix Abbreviated Genitive Month Names Parsing In 3.0 we have fixed the formatting to use the abbreviated genitive month names when having "d" format specifier followed by "MMM". This fix is good as original formatting specs required but we needed to support the parsing when we have such genitive names. * Addressing the feedback Signed-off-by: dotnet-bot <[email protected]>
Dotnet-GitSync-Bot
pushed a commit
to Dotnet-GitSync-Bot/mono
that referenced
this pull request
Aug 27, 2019
* Fix Abbreviated Genitive Month Names Parsing In 3.0 we have fixed the formatting to use the abbreviated genitive month names when having "d" format specifier followed by "MMM". This fix is good as original formatting specs required but we needed to support the parsing when we have such genitive names. * Addressing the feedback Signed-off-by: dotnet-bot <[email protected]>
akoeplinger
pushed a commit
to mono/mono
that referenced
this pull request
Aug 27, 2019
* Fix Abbreviated Genitive Month Names Parsing In 3.0 we have fixed the formatting to use the abbreviated genitive month names when having "d" format specifier followed by "MMM". This fix is good as original formatting specs required but we needed to support the parsing when we have such genitive names. * Addressing the feedback Signed-off-by: dotnet-bot <[email protected]>
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Fix Abbreviated Genitive Month Names Parsing In 3.0 we have fixed the formatting to use the abbreviated genitive month names when having "d" format specifier followed by "MMM". This fix is good as original formatting specs required but we needed to support the parsing when we have such genitive names. * Addressing the feedback Commit migrated from dotnet/coreclr@b6553f3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3.0 we have fixed the formatting to use the abbreviated genitive month names when having "d" format specifier followed by "MMM". This fix is good as original formatting specs required but we needed to support the parsing when we have such genitive names.
https://github.com/dotnet/coreclr/issues/26370