Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

@tarekgh
Copy link
Member

@tarekgh tarekgh commented Aug 27, 2019

In 3.0 we have fixed the formatting to use the abbreviated genitive month names when having "d" format specifier followed by "MMM". This fix is good as original formatting specs required but we needed to support the parsing when we have such genitive names.

In 3.0 we have fixed the formatting to use the abbreviated genitive month names when having "d" format specifier followed by "MMM". This fix is good as original formatting specs required but we needed to support the parsing when we have such genitive names.
@tarekgh
Copy link
Member Author

tarekgh commented Aug 27, 2019

@jkotas jkotas changed the title Fix Abbreviated Genitive Month Names Parsing [release/3.0] Fix Abbreviated Genitive Month Names Parsing Aug 27, 2019
@tarekgh
Copy link
Member Author

tarekgh commented Aug 27, 2019

Description

In last December we have made a fix for the issue https://github.com/dotnet/corefx/issues/2804 allowing formatting dates with Genitive month names. The fix is good but we missed adding a support to the date parser to handle the genitive month names.
On Windows 10, there are 133 cultures with genitive names out of total 848 cultures.

Customer Impact

If the customer app dealing with date and time formatting and parsing functionality will be potentially broken if format a date with genitive months and then try to parse it back to DateTime. The parsing is going to throw exception. Some of the cultures uses date/time formatting pattern with genitive month names specifiers as the default format. For example, culture Ky uses a default short date pattern d-MMM yy produce a genitive month names in the date formatting and parsing such strings is going to throw exception.

Regression?

Yes, although the fix we did is not the real regression but the regression caused because we missed to add the parsing part with the fix.

Risk

The risk is low as we are going to allow the date parser to try the genitive month names so the failing case will start succeed.

Code Review

Stephen Toub

@tarekgh tarekgh merged commit 652fe10 into dotnet:release/3.0 Aug 27, 2019
Dotnet-GitSync-Bot pushed a commit to Dotnet-GitSync-Bot/corefx that referenced this pull request Aug 27, 2019
In 3.0 we have fixed the formatting to use the abbreviated genitive month names when having "d" format specifier followed by "MMM". This fix is good as original formatting specs required but we needed to support the parsing when we have such genitive names.

Signed-off-by: dotnet-bot <[email protected]>
tarekgh added a commit to dotnet/corefx that referenced this pull request Aug 27, 2019
In 3.0 we have fixed the formatting to use the abbreviated genitive month names when having "d" format specifier followed by "MMM". This fix is good as original formatting specs required but we needed to support the parsing when we have such genitive names.

Signed-off-by: dotnet-bot <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant