This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Port graphics metafile refcount fix to avoid disposing the native image multiple times #43017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safern
force-pushed
the
PortDrawingMetafileDispose
branch
2 times, most recently
from
b28e086 to
808ab6a
Compare
…ge multiple times
safern
force-pushed
the
PortDrawingMetafileDispose
branch
from
808ab6a to
0f887e6
Compare
ericstj
approved these changes
Jan 15, 2021
Member
Author
|
Added servicing approved as it was approved over email. |
Anipik
approved these changes
Jan 15, 2021
crummel
pushed a commit
to crummel/dotnet_corefx
that referenced
this pull request
Aug 11, 2021
…ng the native image multiple times. Internal port of: dotnet#43017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports: dotnet/runtime@7939172
Summary
Due to libgdiplus behavior we were disposing metafiles twice causing the app to crash. This adds a ref count to avoid disposing a metafile when a graphics instance still has a reference to it.
Customer Impact
Detected via tests.
Regression?
No.
Testing
Unit tests.
Risk
Low-medium. The fix just adds a ref count to the metafile and avoids disposing it if it is still referenced by a graphics object.
cc: @Anipik