This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[3.1] Port graphics metafile refcount fix to avoid disposing the native image multiple times #43020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge multiple times
Member
Author
|
The build will fail because this needs #43017 to publish the 4.5.2 package to be able to harvest. I will add the feed once we have a build available. |
safern
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports: dotnet/runtime@7939172
Summary
Due to libgdiplus behavior we were disposing metafiles twice causing the app to crash. This adds a ref count to avoid disposing a metafile when a graphics instance still has a reference to it.
Customer Impact
Detected via tests.
Regression?
No.
Testing
Unit tests.
Risk
Low-medium. The fix just adds a ref count to the metafile and avoids disposing it if it is still referenced by a graphics object.
cc: @Anipik