This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Expose Type.GetTypeCode() and Type.Delimiter #6815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
/cc: @weshaggard Could you please review the change. |
| </ItemGroup> | ||
| <ItemGroup> | ||
| <!-- Compile tests against the System.Runtime contract, but copy our local-built implementation for testing --> | ||
| <ProjectReference Include="..\ref\System.Runtime.csproj"> |
Member
There was a problem hiding this comment.
This seems to indicate we are not testing any of the other new System.Runtime APIs higher then 4.0.20?
Author
There was a problem hiding this comment.
Yes, that surprised me as well. The tests I wrote were not able to find new methods so I dug in and found this to be the issue.
Member
|
LGTM |
pallavit
force-pushed
the
ExposeTypeAPIs
branch
from
4d21b39 to
ae203ab
Compare
Author
|
@weshaggard Could you please take a look at the Activator.CreateInstance commit. |
Author
|
Please don't merge I need to make a parallel change in TFS for baseline comparison. |
Member
|
LGTM |
Author
|
Thanks for the review. |
pallavit
added a commit
that referenced
this pull request
Mar 11, 2016
Expose Type.GetTypeCode(), Type.Delimiter and Activator.CreateInstance
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Expose Type.GetTypeCode(), Type.Delimiter and Activator.CreateInstance Commit migrated from dotnet/corefx@251ad14
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.