Consistently xref properties in ArgumentException #174
Conversation
There was a problem hiding this comment.
Thanks for replacing fenced text with links, @ChrisMaddock. One of the links is broken, though -- ParamName is a property of ArgumentException, not Exception.
xml/System/ArgumentException.xml
Outdated
| |`Message`|The error message string.| | ||
| |`ParamName`|The parameter name string.| | ||
| |<xref:System.Exception.Message%2A>|The localized error message string.| | ||
| |<xref:System.Exception.ParamName%2A>|The parameter name string.| |
There was a problem hiding this comment.
This should be <xref:System.ArgumentException.ParamName%2A>
There was a problem hiding this comment.
Thanks @rpetrusha - good spot!
Now you've pointed it out - I've noticed the other xref's are inconsistent in the file. Some reference <xref:System.ArgumentException.Message%2A>, others <xref:System.Exception.Message%2A>. Should they all be referencing ArgumentException, or does it not matter?
There was a problem hiding this comment.
That's a good question, @ChrisMaddock . They actually all should reference ArgumentException, since it overrides the base class Exception.Message.
|
CLA seems stuck. |
|
@rpetrusha Additional changes made - would you be able to take another look? Thanks for the clarification here. 😄 |
There was a problem hiding this comment.
Thanks for making all of the additional changes, @ChrisMaddock. This looks really good. We'll merge once the build completes.
4 participants
Properties in the remarks section of this API page were inconsistently fenced/xref'd. I assume there's no problem xref'ing everything!