Skip to content

Consistently xref properties in ArgumentException #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2018
Merged

Consistently xref properties in ArgumentException #174

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1089be7
Consistently xref properties in ArgumentException
ChrisMaddock May 11, 2018
6b550c4
Review changes
ChrisMaddock May 15, 2018
8c12e0a
Merge branch 'master' into patch-2
mairaw May 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Consistently xref properties in ArgumentException
  • Loading branch information
@ChrisMaddock
ChrisMaddock authored May 11, 2018
commit 1089be703e90b24421a7e9f76c9c5c35566c81c4
8 changes: 4 additions & 4 deletions xml/System/ArgumentException.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@
|Property|Value|
|--------------|-----------|
|<xref:System.Exception.InnerException%2A>|The inner exception reference.|
|`Message`|The error message string.|
|<xref:System.Exception.Message%2A>|The localized error message string.|

]]></format>
</remarks>
Expand Down Expand Up @@ -376,8 +376,8 @@
|Property|Value|
|--------------|-----------|
|<xref:System.Exception.InnerException%2A>|The inner exception reference.|
|`Message`|The error message string.|
|`ParamName`|The parameter name string.|
|<xref:System.Exception.Message%2A>|The localized error message string.|
|<xref:System.Exception.ParamName%2A>|The parameter name string.|
Copy link

@rpetrusha rpetrusha May 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be <xref:System.ArgumentException.ParamName%2A>

Copy link
Contributor Author

@ChrisMaddock ChrisMaddock May 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rpetrusha - good spot!

Now you've pointed it out - I've noticed the other xref's are inconsistent in the file. Some reference <xref:System.ArgumentException.Message%2A>, others <xref:System.Exception.Message%2A>. Should they all be referencing ArgumentException, or does it not matter?

Copy link

@rpetrusha rpetrusha May 14, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good question, @ChrisMaddock . They actually all should reference ArgumentException, since it overrides the base class Exception.Message.


]]></format>
</remarks>
Expand Down Expand Up @@ -541,4 +541,4 @@
</Docs>
</Member>
</Members>
</Type>
</Type>