Skip to content

Fix <seealso> links #4337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 5, 2020
Merged

Fix <seealso> links #4337

merged 4 commits into from
Jun 5, 2020

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented Jun 4, 2020 •
edited
Loading

  • Inline links should use <see> instead of <seealso>. Also, <seealso> links are currently broken.
  • Random grammar and punctuation improvements that I saw while fixing the seealso links.

Preview links:

@dotnet-bot dotnet-bot added this to the June 2020 milestone Jun 4, 2020
@gewarren gewarren changed the title Fix see cref links Fix \<seealso> links Jun 4, 2020
@gewarren gewarren changed the title Fix \<seealso> links Fix <seealso> links Jun 4, 2020
@gewarren gewarren requested a review from tdykstra June 5, 2020 18:58
tdykstra
tdykstra approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gewarren
Copy link
Contributor Author

gewarren commented Jun 5, 2020

Thanks for the review!

@gewarren gewarren merged commit 485eb38 into dotnet:master Jun 5, 2020
@gewarren gewarren deleted the seealso branch June 5, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tdykstra tdykstra tdykstra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

June 2020

Development

Successfully merging this pull request may close these issues.

3 participants

@gewarren @tdykstra @dotnet-bot