Skip to content

Fix <seealso> links #4337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2020
Merged

Fix <seealso> links #4337

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
17c8f21
fix see cref links
gewarren Jun 4, 2020
35295bb
review on staging
gewarren Jun 5, 2020
31ac5b0
more review on staging
gewarren Jun 5, 2020
f6f3bd0
pull upstream master
gewarren Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more review on staging
  • Loading branch information
@gewarren
gewarren committed Jun 5, 2020
commit 31ac5b0787b97f85ac9748c1818779a7701b3fea
22 changes: 11 additions & 11 deletions xml/Microsoft.Extensions.DependencyInjection/OptionsServiceCollectionExtensions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
<Docs>
<typeparam name="TOptions">The options type to be configured.</typeparam>
<param name="services">The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> to add the services to.</param>
<summary>Gets an options builder that forwards Configure calls for the same <typeparamref name="TOptions" /> to the underlying service collection.</summary>
<summary>Gets an options builder that forwards <c>Configure</c> calls for the same named <typeparamref name="TOptions" /> to the underlying service collection.</summary>
<returns>The <see cref="T:Microsoft.Extensions.Options.OptionsBuilder`1" /> so that configure calls can be chained in it.</returns>
<remarks>To be added.</remarks>
</Docs>
Expand Down Expand Up @@ -124,8 +124,8 @@
<typeparam name="TOptions">The options type to be configured.</typeparam>
<param name="services">The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> to add the services to.</param>
<param name="name">The name of the options instance.</param>
<summary>Gets an options builder that forwards Configure calls for the same named <typeparamref name="TOptions" /> to the underlying service collection.</summary>
<returns>The <see cref="T:Microsoft.Extensions.Options.OptionsBuilder`1" /> so that configure calls can be chained in it.</returns>
<summary>Gets an options builder that forwards <c>Configure</c> calls for the same named <typeparamref name="TOptions" /> to the underlying service collection.</summary>
<returns>The <see cref="T:Microsoft.Extensions.Options.OptionsBuilder`1" /> so that <c>Configure</c> calls can be chained in it.</returns>
<remarks>To be added.</remarks>
</Docs>
</Member>
Expand Down Expand Up @@ -165,7 +165,7 @@
<typeparam name="TOptions">The options type to be configured.</typeparam>
<param name="services">The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> to add the services to.</param>
<param name="configureOptions">The action used to configure the options.</param>
<summary>Registers an action used to configure a particular type of options. These are run before all <see cref="M:Microsoft.Extensions.DependencyInjection.OptionsServiceCollectionExtensions.PostConfigure``1(Microsoft.Extensions.DependencyInjection.IServiceCollection,System.Action{``0})" />.</summary>
<summary>Registers an action used to configure a particular type of options. These are run before <see cref="M:Microsoft.Extensions.DependencyInjection.OptionsServiceCollectionExtensions.PostConfigure``1(Microsoft.Extensions.DependencyInjection.IServiceCollection,System.Action{``0})" />.</summary>
<returns>The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> so that additional calls can be chained.</returns>
<remarks>To be added.</remarks>
</Docs>
Expand Down Expand Up @@ -206,7 +206,7 @@
<param name="services">The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> to add the services to.</param>
<param name="name">The name of the options instance.</param>
<param name="configureOptions">The action used to configure the options.</param>
<summary>Registers an action used to configure a particular type of options. These are run before all <see cref="M:Microsoft.Extensions.DependencyInjection.OptionsServiceCollectionExtensions.PostConfigure``1(Microsoft.Extensions.DependencyInjection.IServiceCollection,System.Action{``0})" />.</summary>
<summary>Registers an action used to configure a particular type of options. These are run before <see cref="M:Microsoft.Extensions.DependencyInjection.OptionsServiceCollectionExtensions.PostConfigure``1(Microsoft.Extensions.DependencyInjection.IServiceCollection,System.Action{``0})" />.</summary>
<returns>The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> so that additional calls can be chained.</returns>
<remarks>To be added.</remarks>
</Docs>
Expand Down Expand Up @@ -275,7 +275,7 @@
<Docs>
<param name="services">The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> to add the services to.</param>
<param name="configureInstance">The instance that will configure options.</param>
<summary>Registers an object that will have all of its I[Post]ConfigureOptions registered.</summary>
<summary>Registers an object that will have all of its <c>I[Post]ConfigureOptions</c> registered.</summary>
<returns>The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> so that additional calls can be chained.</returns>
<remarks>To be added.</remarks>
</Docs>
Expand Down Expand Up @@ -305,7 +305,7 @@
<Docs>
<param name="services">The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> to add the services to.</param>
<param name="configureType">The type that will configure options.</param>
<summary>Registers a type that will have all of its I[Post]ConfigureOptions registered.</summary>
<summary>Registers a type that will have all of its <c>I[Post]ConfigureOptions</c> registered.</summary>
<returns>The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> so that additional calls can be chained.</returns>
<remarks>To be added.</remarks>
</Docs>
Expand Down Expand Up @@ -341,7 +341,7 @@
<Docs>
<typeparam name="TConfigureOptions">The type that will configure options.</typeparam>
<param name="services">The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> to add the services to.</param>
<summary>Registers a type that will have all of its I[Post]ConfigureOptions registered.</summary>
<summary>Registers a type that will have all of its <c>I[Post]ConfigureOptions</c> registered.</summary>
<returns>The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> so that additional calls can be chained.</returns>
<remarks>To be added.</remarks>
</Docs>
Expand Down Expand Up @@ -380,7 +380,7 @@
<typeparam name="TOptions">The options type to be configured.</typeparam>
<param name="services">The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> to add the services to.</param>
<param name="configureOptions">The action used to configure the options.</param>
<summary>Registers an action used to initialize a particular type of options. These are run after all <see cref="M:Microsoft.Extensions.DependencyInjection.OptionsServiceCollectionExtensions.Configure``1(Microsoft.Extensions.DependencyInjection.IServiceCollection,System.Action{``0})" />.</summary>
<summary>Registers an action used to initialize a particular type of options. These are run after <see cref="M:Microsoft.Extensions.DependencyInjection.OptionsServiceCollectionExtensions.Configure``1(Microsoft.Extensions.DependencyInjection.IServiceCollection,System.Action{``0})" />.</summary>
<returns>The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> so that additional calls can be chained.</returns>
<remarks>To be added.</remarks>
</Docs>
Expand Down Expand Up @@ -421,7 +421,7 @@
<param name="services">The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> to add the services to.</param>
<param name="name">The name of the options instance.</param>
<param name="configureOptions">The action used to configure the options.</param>
<summary>Registers an action used to configure a particular type of options. These are run after all <see cref="M:Microsoft.Extensions.DependencyInjection.OptionsServiceCollectionExtensions.Configure``1(Microsoft.Extensions.DependencyInjection.IServiceCollection,System.Action{``0})" />.</summary>
<summary>Registers an action used to configure a particular type of options. These are run after <see cref="M:Microsoft.Extensions.DependencyInjection.OptionsServiceCollectionExtensions.Configure``1(Microsoft.Extensions.DependencyInjection.IServiceCollection,System.Action{``0})" />.</summary>
<returns>The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> so that additional calls can be chained.</returns>
<remarks>To be added.</remarks>
</Docs>
Expand Down Expand Up @@ -460,7 +460,7 @@
<typeparam name="TOptions">The options type to be configured.</typeparam>
<param name="services">The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> to add the services to.</param>
<param name="configureOptions">The action used to configure the options.</param>
<summary>Registers an action used to post configure all instances of a particular type of options. These are run after all <see cref="M:Microsoft.Extensions.DependencyInjection.OptionsServiceCollectionExtensions.Configure``1(Microsoft.Extensions.DependencyInjection.IServiceCollection,System.Action{``0})" />.</summary>
<summary>Registers an action used to post configure all instances of a particular type of options. These are run after <see cref="M:Microsoft.Extensions.DependencyInjection.OptionsServiceCollectionExtensions.Configure``1(Microsoft.Extensions.DependencyInjection.IServiceCollection,System.Action{``0})" />.</summary>
<returns>The <see cref="T:Microsoft.Extensions.DependencyInjection.IServiceCollection" /> so that additional calls can be chained.</returns>
<remarks>To be added.</remarks>
</Docs>
Expand Down
7 changes: 3 additions & 4 deletions xml/Microsoft.Extensions.FileProviders.Physical/PhysicalFilesWatcher.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,8 @@
<Docs>
<param name="root">Root directory for the watcher.</param>
<param name="fileSystemWatcher">The wrapped watcher that is watching <paramref name="root" />.</param>
<param name="pollForChanges"><see langword="true" /> when the watcher should use polling to trigger instances of
<see cref="T:Microsoft.Extensions.Primitives.IChangeToken" /> created by <see cref="M:Microsoft.Extensions.FileProviders.Physical.PhysicalFilesWatcher.CreateFileChangeToken(System.String)" />.</param>
<summary>Initializes an instance of <see cref="T:Microsoft.Extensions.FileProviders.Physical.PhysicalFilesWatcher" /> that watches files in <paramref name="root" />. Wraps an instance of <see cref="T:System.IO.FileSystemWatcher" /></summary>
<param name="pollForChanges"><see langword="true" /> when the watcher should use polling to trigger instances of <see cref="T:Microsoft.Extensions.Primitives.IChangeToken" /> created by <see cref="M:Microsoft.Extensions.FileProviders.Physical.PhysicalFilesWatcher.CreateFileChangeToken(System.String)" />.</param>
<summary>Initializes an instance of <see cref="T:Microsoft.Extensions.FileProviders.Physical.PhysicalFilesWatcher" /> that watches files in <paramref name="root" />. Wraps an instance of <see cref="T:System.IO.FileSystemWatcher" />.</summary>
<remarks>To be added.</remarks>
</Docs>
</Member>
Expand Down Expand Up @@ -90,7 +89,7 @@
<param name="pollForChanges"><see langword="true" /> when the watcher should use polling to trigger instances of
<see cref="T:Microsoft.Extensions.Primitives.IChangeToken" /> created by <see cref="M:Microsoft.Extensions.FileProviders.Physical.PhysicalFilesWatcher.CreateFileChangeToken(System.String)" />.</param>
<param name="filters">Specifies which files or directories are excluded. Notifications of changes to are not raised to these.</param>
<summary>Initializes an instance of <see cref="T:Microsoft.Extensions.FileProviders.Physical.PhysicalFilesWatcher" /> that watches files in <paramref name="root" />. Wraps an instance of <see cref="T:System.IO.FileSystemWatcher" /></summary>
<summary>Initializes an instance of <see cref="T:Microsoft.Extensions.FileProviders.Physical.PhysicalFilesWatcher" /> that watches files in <paramref name="root" />. Wraps an instance of <see cref="T:System.IO.FileSystemWatcher" />.</summary>
<remarks>To be added.</remarks>
</Docs>
</Member>
Expand Down
5 changes: 2 additions & 3 deletions xml/Microsoft.Extensions.FileProviders/PhysicalFileProvider.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,8 +321,7 @@
</para>
</summary>
<value>
The default value of this property is determined by the value of environment variable named <c>DOTNET_USE_POLLING_FILE_WATCHER</c>.
When <see langword="true" /> or <c>1</c>, this property defaults to <see langword="true" />; otherwise false.
The default value of this property is determined by the value of environment variable named <c>DOTNET_USE_POLLING_FILE_WATCHER</c>. When <see langword="true" /> or <c>1</c>, this property defaults to <see langword="true" />; otherwise <see langword="false" />.
</value>
<remarks>To be added.</remarks>
<altmember cref="P:Microsoft.Extensions.FileProviders.PhysicalFileProvider.UseActivePolling" />
Expand Down Expand Up @@ -357,7 +356,7 @@
</Parameters>
<Docs>
<param name="filter">
Filter string used to determine what files or folders to monitor. Examples: <c>**/*.cs</c>, <c>*.*</c>, <c>subFolder/**/*.cshtml</c>.
Filter string used to determine what files or folders to monitor. Examples: <c>\*\*/\*.cs</c>, <c>\*.\*</c>, <c>subfolder/\*\*/\*.cshtml</c>.
</param>
<summary>
<para>Creates an <see cref="T:Microsoft.Extensions.Primitives.IChangeToken" /> for the specified <paramref name="filter" />.</para>
Expand Down
16 changes: 8 additions & 8 deletions xml/Microsoft.Extensions.FileSystemGlobbing/MatcherExtensions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,8 @@
</Parameter>
</Parameters>
<Docs>
<param name="matcher">The matcher to which the exclude patterns are added</param>
<param name="excludePatternsGroups">A list of globbing patterns</param>
<param name="matcher">The matcher to which the exclude patterns are added.</param>
<param name="excludePatternsGroups">A list of globbing patterns.</param>
<summary>Adds multiple exclude patterns to <see cref="T:Microsoft.Extensions.FileSystemGlobbing.Matcher" />.</summary>
<remarks>To be added.</remarks>
<altmember cref="M:Microsoft.Extensions.FileSystemGlobbing.Matcher.AddExclude(System.String)" />
Expand Down Expand Up @@ -95,12 +95,12 @@
</Parameter>
</Parameters>
<Docs>
<param name="matcher">The matcher to which the include patterns are added</param>
<param name="includePatternsGroups">A list of globbing patterns</param>
<param name="matcher">The matcher to which the include patterns are added.</param>
<param name="includePatternsGroups">A list of globbing patterns.</param>
<summary>Adds multiple patterns to include in <see cref="T:Microsoft.Extensions.FileSystemGlobbing.Matcher" />.</summary>
<remarks>To be added.</remarks>
<altmember cref="M:Microsoft.Extensions.FileSystemGlobbing.Matcher.AddInclude(System.String)" />
</Docs>
<altmember cref="M:Microsoft.Extensions.FileSystemGlobbing.Matcher.AddInclude(System.String)" />
</Member>
<Member MemberName="GetResultsInFullPath">
<MemberSignature Language="C#" Value="public static System.Collections.Generic.IEnumerable&lt;string&gt; GetResultsInFullPath (this Microsoft.Extensions.FileSystemGlobbing.Matcher matcher, string directoryPath);" />
Expand Down Expand Up @@ -128,9 +128,9 @@
<Parameter Name="directoryPath" Type="System.String" />
</Parameters>
<Docs>
<param name="matcher">The matcher</param>
<param name="directoryPath">The root directory for the search</param>
<summary>Searches the directory specified for all files matching patterns added to this instance of <see cref="T:Microsoft.Extensions.FileSystemGlobbing.Matcher" /></summary>
<param name="matcher">The matcher.</param>
<param name="directoryPath">The root directory for the search.</param>
<summary>Searches the specified directory for all files matching patterns added to this instance of <see cref="T:Microsoft.Extensions.FileSystemGlobbing.Matcher" />.</summary>
<returns>Absolute file paths of all files matched. Empty enumerable if no files matched given patterns.</returns>
<remarks>To be added.</remarks>
</Docs>
Expand Down