-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Made clear DNS subsystem is used #653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation was confusing because is worded as if it queried using the DNS protocol, not the subsystem. If it was just using the DNS protocol, it could be bypassing the hosts file, similar to the nslookup tool. Confirmed this code does not bypass the hosts file. See issue: dotnet/docs#8418 (comment)
karelz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should leave out "Because the DNS subsystem is used, entries in the hosts file will be returned."
That is Linux specific + I don't think it is necessary. Changing the DNS server to DNS subsystem is IMO fine.
|
@davidsh, could you take a look, please? |
|
@karelz, Sorry, what do you mean "Linux specific". I'm only focusing on Windows, which also has a hosts file. |
|
@samrueby ok, I didn't realize that. Either way, I don't think the last sentence is necessary or super-valuable IMO. |
|
@karelz Okay. Obviously I'm biased but I think it removes any question of how the host is resolved. Maybe it could be worded in a better way? |
|
@samrueby I don't think it is about wording. Clarifying that it is about DNS subsystem vs. protocol makes sense to me. |
|
I think the change is ok, except this final sentence should not be added: "Because the DNS subsystem is used, entries in the hosts file will be returned. " I think that adds too much implementation detail to the documentation. These APIs do not actually call DNS directly. They call operating system "name resolver" APIs first. Then those operating system APIs will use various mechanisms including DNS protocol to resolve the name. |
|
Updated. |
Documentation was confusing because is worded as if it queried using the DNS protocol, not the subsystem. If it was just using the DNS protocol, it could be bypassing the hosts file, similar to the nslookup tool. Confirmed this code does not bypass the hosts file. See issue: dotnet/docs#8418 (comment)
Fixes dotnet/docs#8418