Skip to content

Made clear DNS subsystem is used #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karelz merged 2 commits into from
Oct 29, 2018
Merged

Made clear DNS subsystem is used #653

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f59f22
Made clear DNS subsystem is used
samrueby Oct 23, 2018
2d2134d
Removed sentence per feedback
samrueby Oct 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Made clear DNS subsystem is used 
Documentation was confusing because is worded as if it queried using the DNS protocol, not the subsystem. If it was just using the DNS protocol, it could be bypassing the hosts file, similar to the nslookup tool. Confirmed this code does not bypass the hosts file. See issue: dotnet/docs#8418 (comment)
  • Loading branch information
@samrueby
samrueby authored Oct 23, 2018
commit 8f59f221408d9d9b301274754376a762ddb452b6
4 changes: 2 additions & 2 deletions xml/System.Net/Dns.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,7 @@
<format type="text/markdown"><![CDATA[

## Remarks
The <xref:System.Net.Dns.GetHostAddresses%2A> method queries a DNS server for the IP addresses associated with a host name. If `hostNameOrAddress` is an IP address, this address is returned without querying the DNS server.
The <xref:System.Net.Dns.GetHostAddresses%2A> method queries the DNS subsystem for the IP addresses associated with a host name. If `hostNameOrAddress` is an IP address, this address is returned without querying the DNS server. Because the DNS subsystem is used, entries in the hosts file will be returned.

If an empty string is passed as the `hostNameOrAddress` argument, then this method returns the IPv4 and IPv6 addresses of the local host.

Expand Down Expand Up @@ -1400,4 +1400,4 @@
</Docs>
</Member>
</Members>
</Type>
</Type>