Skip to content

Add remark for JsonNumberHandling of Special Numbers in System.Text.Json #7488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gewarren merged 8 commits into from
Jan 3, 2022
Merged

Add remark for JsonNumberHandling of Special Numbers in System.Text.Json #7488

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
21db112
Update JsonNumberHandling.xml
deeprobin Dec 13, 2021
0974116
Usage of more insightful remark
deeprobin Dec 14, 2021
99488ed
Simplify wording
deeprobin Dec 15, 2021
138f228
Apply suggestions from code review
deeprobin Dec 18, 2021
fcd1862
Update remark
deeprobin Dec 18, 2021
4c70e4a
Move remark and change wording
deeprobin Dec 20, 2021
48502c8
Fix typo
deeprobin Dec 20, 2021
ae2a9ee
Add enum-lvl remark
deeprobin Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions xml/System.Text.Json.Serialization/JsonNumberHandling.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
</Attributes>
<Docs>
<summary>Determines how <see cref="T:System.Text.Json.JsonSerializer" /> handles numbers when serializing and deserializing.</summary>
<remarks>To be added.</remarks>
<remarks>The behavior of <see cref="F:System.Text.Json.Serialization.JsonNumberHandling.WriteAsString"/> and <see cref="F:System.Text.Json.Serialization.JsonNumberHandling.AllowNamedFloatingPointLiterals"/> is not defined by the JSON specification. Altering the default number handling can potentially produce JSON that cannot be parsed by other JSON implementations.</remarks>
</Docs>
<Members>
<Member MemberName="AllowNamedFloatingPointLiterals">
Expand All @@ -43,7 +43,7 @@
<MemberValue>4</MemberValue>
<Docs>
<summary>The "NaN", "Infinity", and "-Infinity" <see cref="F:System.Text.Json.JsonTokenType.String" /> tokens can be read as floating-point constants, and the <see cref="T:System.Single" /> and <see cref="T:System.Double" /> values for these constants will be written as their corresponding JSON string representations.</summary>
<remarks>To be added.</remarks>
<remarks>This field is not defined by the JSON specification. Altering the default number handling can potentially produce JSON that cannot be parsed by other JSON implementations.</remarks>
</Docs>
</Member>
<Member MemberName="AllowReadingFromString">
Expand Down Expand Up @@ -109,7 +109,7 @@
<MemberValue>2</MemberValue>
<Docs>
<summary>Numbers will be written as JSON strings (with quotes), not as JSON numbers.</summary>
<remarks>To be added.</remarks>
<remarks>This field is not defined by the JSON specification. Altering the default number handling can potentially produce JSON that cannot be parsed by other JSON implementations.</remarks>
</Docs>
</Member>
</Members>
Expand Down