Skip to content

Conversation

@deeprobin
Copy link
Contributor

@deeprobin deeprobin commented Dec 13, 2021

@deeprobin deeprobin requested a review from a team as a code owner December 13, 2021 18:55
@deeprobin deeprobin changed the title Add remark for Special Numbers in S Add remark for Special Numbers in System.Text.Json Dec 13, 2021
@deeprobin deeprobin changed the title Add remark for Special Numbers in System.Text.Json Add remark for JsonNumberHandling of Special Numbers in System.Text.Json Dec 13, 2021
@opbld30
Copy link

opbld30 commented Dec 13, 2021

Docs Build status updates of commit 21db112:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.Json.Serialization/JsonNumberHandling.xml 💡Suggestion View Details

xml/System.Text.Json.Serialization/JsonNumberHandling.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@ghost
Copy link

ghost commented Dec 13, 2021

Tagging subscribers to this area: @dotnet/area-system-text-json
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

See dotnet/runtime#48926

/cc @layomia
/cc @GrabYourPitchforks

Author: deeprobin
Assignees: -
Labels:

area-System.Text.Json

Milestone: -

@deeprobin deeprobin requested a review from krwq December 14, 2021 17:25
@opbld34
Copy link

opbld34 commented Dec 14, 2021

Docs Build status updates of commit 0974116:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.Json.Serialization/JsonNumberHandling.xml 💡Suggestion View Details

xml/System.Text.Json.Serialization/JsonNumberHandling.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld34
Copy link

opbld34 commented Dec 15, 2021

Docs Build status updates of commit 99488ed:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.Json.Serialization/JsonNumberHandling.xml 💡Suggestion View Details

xml/System.Text.Json.Serialization/JsonNumberHandling.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33
Copy link

opbld33 commented Dec 18, 2021

Docs Build status updates of commit 138f228:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.Json.Serialization/JsonNumberHandling.xml 💡Suggestion View Details

xml/System.Text.Json.Serialization/JsonNumberHandling.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld31
Copy link

opbld31 commented Dec 18, 2021

Docs Build status updates of commit fcd1862:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.Json.Serialization/JsonNumberHandling.xml 💡Suggestion View Details

xml/System.Text.Json.Serialization/JsonNumberHandling.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren
Copy link
Contributor

One thing to note is that currently, remarks on enum fields aren't displayed in the docs anywhere. You could add a general remark to the enum as a whole, and just call out the two fields specifically.

deeprobin added a commit to deeprobin/runtime that referenced this pull request Dec 20, 2021
@deeprobin
Copy link
Contributor Author

One thing to note is that currently, remarks on enum fields aren't displayed in the docs anywhere. You could add a general remark to the enum as a whole, and just call out the two fields specifically.

@layomia What is your approach to this?

@opbld31
Copy link

opbld31 commented Dec 20, 2021

Docs Build status updates of commit 4c70e4a:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.Json.Serialization/JsonNumberHandling.xml 💡Suggestion View Details

xml/System.Text.Json.Serialization/JsonNumberHandling.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33
Copy link

opbld33 commented Dec 20, 2021

Docs Build status updates of commit 48502c8:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.Json.Serialization/JsonNumberHandling.xml 💡Suggestion View Details

xml/System.Text.Json.Serialization/JsonNumberHandling.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@deeprobin deeprobin requested a review from gewarren December 20, 2021 21:25
@deeprobin
Copy link
Contributor Author

One thing to note is that currently, remarks on enum fields aren't displayed in the docs anywhere. You could add a general remark to the enum as a whole, and just call out the two fields specifically.

@layomia What is your approach to this?

@gewarren See dotnet/runtime#62690 (comment)

@opbld31
Copy link

opbld31 commented Dec 22, 2021

Docs Build status updates of commit ae2a9ee:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Text.Json.Serialization/JsonNumberHandling.xml 💡Suggestion View Details

xml/System.Text.Json.Serialization/JsonNumberHandling.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Enum_NoRemarks] Please note: <remarks> node on Enum fields will be ignored.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren merged commit 7b8e508 into dotnet:main Jan 3, 2022
@gewarren
Copy link
Contributor

gewarren commented Jan 3, 2022

Thanks @deeprobin

layomia added a commit to dotnet/runtime that referenced this pull request Jan 10, 2022
…ritten as valid JSON. (#62690)

* Change documentation

* Move doc addition in remark block

Co-authored-by: Layomi Akinrinade <[email protected]>

* Add remarks block

* Update exception text

* Fix characters

* Update exception message

Co-authored-by: Layomi Akinrinade <[email protected]>

* Usage of a more insightful message

Co-authored-by: Krzysztof Wicher <[email protected]>

* Usage of more insightful remark

* Simplify wording

* Update remark

* Change wording

See dotnet/dotnet-api-docs#7488 (comment)

* Change wording

Co-authored-by: Layomi Akinrinade <[email protected]>

* Change wording

* Remove duplicate closing tag

* Add enum-lvl remark

Co-authored-by: Layomi Akinrinade <[email protected]>
Co-authored-by: Krzysztof Wicher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants