-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add remark for JsonNumberHandling of Special Numbers in System.Text.Json #7488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Docs Build status updates of commit 21db112: ✅ Validation status: passed
xml/System.Text.Json.Serialization/JsonNumberHandling.xml
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Tagging subscribers to this area: @dotnet/area-system-text-json Issue DetailsSummary/cc @layomia
|
|
Docs Build status updates of commit 0974116: ✅ Validation status: passed
xml/System.Text.Json.Serialization/JsonNumberHandling.xml
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit 99488ed: ✅ Validation status: passed
xml/System.Text.Json.Serialization/JsonNumberHandling.xml
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Co-authored-by: Genevieve Warren <[email protected]>
|
Docs Build status updates of commit 138f228: ✅ Validation status: passed
xml/System.Text.Json.Serialization/JsonNumberHandling.xml
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit fcd1862: ✅ Validation status: passed
xml/System.Text.Json.Serialization/JsonNumberHandling.xml
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
One thing to note is that currently, remarks on enum fields aren't displayed in the docs anywhere. You could add a general remark to the enum as a whole, and just call out the two fields specifically. |
@layomia What is your approach to this? |
|
Docs Build status updates of commit 4c70e4a: ✅ Validation status: passed
xml/System.Text.Json.Serialization/JsonNumberHandling.xml
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Docs Build status updates of commit 48502c8: ✅ Validation status: passed
xml/System.Text.Json.Serialization/JsonNumberHandling.xml
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
|
Docs Build status updates of commit ae2a9ee: ✅ Validation status: passed
xml/System.Text.Json.Serialization/JsonNumberHandling.xml
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
|
Thanks @deeprobin |
…ritten as valid JSON. (#62690) * Change documentation * Move doc addition in remark block Co-authored-by: Layomi Akinrinade <[email protected]> * Add remarks block * Update exception text * Fix characters * Update exception message Co-authored-by: Layomi Akinrinade <[email protected]> * Usage of a more insightful message Co-authored-by: Krzysztof Wicher <[email protected]> * Usage of more insightful remark * Simplify wording * Update remark * Change wording See dotnet/dotnet-api-docs#7488 (comment) * Change wording Co-authored-by: Layomi Akinrinade <[email protected]> * Change wording * Remove duplicate closing tag * Add enum-lvl remark Co-authored-by: Layomi Akinrinade <[email protected]> Co-authored-by: Krzysztof Wicher <[email protected]>
Summary
See dotnet/runtime#48926
/cc @layomia
/cc @GrabYourPitchforks