Add comments for new System.Net.Http.Json members #9302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAdd comments for new Contributes to dotnet/runtime#88569.
|
This comment was marked as outdated.
This comment was marked as outdated.
|
Learn Build status updates of commit 68c9f18: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
carlossanlop
approved these changes
Sep 18, 2023
Contributor
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
LGTM. I'd provide suggestions to show the <see cref""/> for the jsonTypeInfo parameters but most of those docs predate this effort so I guess they can stay that way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comments for new
System.Net.Http.Jsonmembers.Contributes to dotnet/runtime#88569.