-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Add missing System.Net.Http.Json comments #92223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsContributes to #88569.
|
...s/System.Net.Http.Json/src/System/Net/Http/Json/HttpContentJsonExtensions.AsyncEnumerable.cs
Outdated
Show resolved
Hide resolved
wfurt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eiriktsarpalis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
| /// <param name="requestUri">The Uri the request is sent to.</param> | ||
| /// <param name="type">The type of the object to deserialize to and return.</param> | ||
| /// <param name="context">Source generated JsonSerializerContext used to control the deserialization behavior.</param> | ||
| /// <param name="context">The JsonSerializerContext used to control the deserialization behavior.</param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically a JsonSerializerContext could have been manually extended by the user and not by a source generator, but I think the change is ok otherwise.
Contributes to #88569.
Ported to docs in dotnet/dotnet-api-docs#9302