Skip to content

[nightly] Update dependencies from dotnet/installer #4628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lbussell merged 3 commits into from
May 26, 2023
Merged

[nightly] Update dependencies from dotnet/installer #4628

lbussell merged 3 commits into from
May 26, 2023

Conversation

@dotnet-docker-bot
Copy link
Contributor

@dotnet-docker-bot dotnet-docker-bot commented May 19, 2023 •
edited
Loading

No description provided.

@dotnet-docker-bot dotnet-docker-bot requested a review from a team as a code owner May 19, 2023 13:03
@dotnet-docker-bot dotnet-docker-bot force-pushed the nightly-UpdateDependencies-nightly-From-dotnet-installer branch from 6aebb36 to f435eda Compare May 19, 2023 13:03
@ghost ghost added the untriaged label May 19, 2023
@ghost
Copy link

ghost commented May 19, 2023

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@mthalman mthalman mentioned this pull request May 19, 2023
Closed
5 tasks
@mthalman
Copy link
Member

mthalman commented May 19, 2023

PowerShell fails to execute with these changes. I've logged PowerShell/PowerShell#19679

@dotnet-docker-bot
Copy link
Contributor Author

dotnet-docker-bot commented May 22, 2023

Discarded f435eda: [nightly] Update dependencies from dotnet/installer

@dotnet-docker-bot dotnet-docker-bot force-pushed the nightly-UpdateDependencies-nightly-From-dotnet-installer branch from f435eda to 36754ff Compare May 22, 2023 13:04
@dotnet-docker-bot
Copy link
Contributor Author

dotnet-docker-bot commented May 23, 2023

Discarded 36754ff: [nightly] Update dependencies from dotnet/installer

@dotnet-docker-bot dotnet-docker-bot force-pushed the nightly-UpdateDependencies-nightly-From-dotnet-installer branch from 36754ff to 1211475 Compare May 23, 2023 13:04
@lbussell lbussell mentioned this pull request May 23, 2023
Merged
@dotnet-docker-bot
Copy link
Contributor Author

dotnet-docker-bot commented May 24, 2023

Discarded 1211475: [nightly] Update dependencies from dotnet/installer

@dotnet-docker-bot dotnet-docker-bot force-pushed the nightly-UpdateDependencies-nightly-From-dotnet-installer branch from 1211475 to 59d601e Compare May 24, 2023 13:03
@dotnet-docker-bot
Copy link
Contributor Author

dotnet-docker-bot commented May 25, 2023

Discarded 59d601e: [nightly] Update dependencies from dotnet/installer

@dotnet-docker-bot dotnet-docker-bot force-pushed the nightly-UpdateDependencies-nightly-From-dotnet-installer branch from 59d601e to 621b52e Compare May 25, 2023 13:03
@lbussell lbussell requested a review from mthalman May 25, 2023 22:29
@dotnet-docker-bot
Copy link
Contributor Author

dotnet-docker-bot commented May 26, 2023

Couldn't update this pull request: Head commit author 'Logan Bussell' is not 'dotnet-docker-bot'
Would have applied '[nightly] Update dependencies from dotnet/installer'

mthalman
mthalman approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad this works! Just one suggested change.

@lbussell lbussell mentioned this pull request May 26, 2023
Closed
@lbussell lbussell merged commit d866f74 into dotnet:nightly May 26, 2023
@mthalman mthalman mentioned this pull request Aug 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lbussell lbussell lbussell left review comments

@mthalman mthalman mthalman approved these changes

Assignees

No one assigned

Labels

untriaged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dotnet-docker-bot @mthalman @lbussell