Add Dockerfiles for alpine3.18 #4629

lbussell · 2023-05-19T20:57:26Z

Release issue: https://github.com/dotnet/release/issues/541

MichaelSimons · 2023-05-22T13:00:27Z

README.aspnet.md

 7.0.5-bullseye-slim-arm64v8, 7.0-bullseye-slim-arm64v8, 7.0.5-bullseye-slim, 7.0-bullseye-slim, 7.0.5, 7.0 | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/aspnet/7.0/bullseye-slim/arm64v8/Dockerfile) | Debian 11
-7.0.5-alpine3.17-arm64v8, 7.0-alpine3.17-arm64v8, 7.0-alpine-arm64v8, 7.0.5-alpine3.17, 7.0-alpine3.17, 7.0-alpine | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/aspnet/7.0/alpine3.17/arm64v8/Dockerfile) | Alpine 3.17
+7.0.5-alpine3.17-arm64v8, 7.0-alpine3.17-arm64v8, 7.0.5-alpine3.17, 7.0-alpine3.17, 7.0-alpine | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/aspnet/7.0/alpine3.17/arm64v8/Dockerfile) | Alpine 3.17
+7.0.5-alpine3.18-arm64v8, 7.0-alpine3.18-arm64v8, 7.0-alpine-arm64v8, 7.0.5-alpine3.18, 7.0-alpine3.18 | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/aspnet/7.0/alpine3.18/arm64v8/Dockerfile) | Alpine 3.18


The 7.0-alpine-arm64v8 floating tag should stay pointing to alpine 3.17

README.runtime.md

MichaelSimons · 2023-05-22T13:02:48Z

README.runtime.md

 -----------| -------------| -------------
 7.0.5-bullseye-slim-arm64v8, 7.0-bullseye-slim-arm64v8, 7.0.5-bullseye-slim, 7.0-bullseye-slim, 7.0.5, 7.0 | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/runtime/7.0/bullseye-slim/arm64v8/Dockerfile) | Debian 11
-7.0.5-alpine3.17-arm64v8, 7.0-alpine3.17-arm64v8, 7.0-alpine-arm64v8, 7.0.5-alpine3.17, 7.0-alpine3.17, 7.0-alpine | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/runtime/7.0/alpine3.17/arm64v8/Dockerfile) | Alpine 3.17
+7.0.5-alpine3.17-arm64v8, 7.0-alpine3.17-arm64v8, 7.0.5-alpine3.17, 7.0-alpine3.17, 7.0-alpine | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/runtime/7.0/alpine3.17/arm64v8/Dockerfile) | Alpine 3.17


Looks like the 7.0-alpine-arm64v8 tag was dropped.

MichaelSimons · 2023-05-22T13:03:11Z

README.runtime.md

 -----------| -------------| -------------
 7.0.5-bullseye-slim-arm32v7, 7.0-bullseye-slim-arm32v7, 7.0.5-bullseye-slim, 7.0-bullseye-slim, 7.0.5, 7.0 | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/runtime/7.0/bullseye-slim/arm32v7/Dockerfile) | Debian 11
-7.0.5-alpine3.17-arm32v7, 7.0-alpine3.17-arm32v7, 7.0-alpine-arm32v7, 7.0.5-alpine3.17, 7.0-alpine3.17, 7.0-alpine | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/runtime/7.0/alpine3.17/arm32v7/Dockerfile) | Alpine 3.17
+7.0.5-alpine3.17-arm32v7, 7.0-alpine3.17-arm32v7, 7.0.5-alpine3.17, 7.0-alpine3.17, 7.0-alpine | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/runtime/7.0/alpine3.17/arm32v7/Dockerfile) | Alpine 3.17


Looks like the 7.0-alpine-arm32v7 tag was dropped.

MichaelSimons · 2023-05-22T13:03:48Z

README.sdk.md

 -----------| -------------| -------------
 7.0.302-bullseye-slim-arm64v8, 7.0-bullseye-slim-arm64v8, 7.0.302-bullseye-slim, 7.0-bullseye-slim, 7.0.302, 7.0 | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/sdk/7.0/bullseye-slim/arm64v8/Dockerfile) | Debian 11
-7.0.302-alpine3.17-arm64v8, 7.0-alpine3.17-arm64v8, 7.0-alpine-arm64v8, 7.0.302-alpine3.17, 7.0-alpine3.17, 7.0-alpine | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/sdk/7.0/alpine3.17/arm64v8/Dockerfile) | Alpine 3.17
+7.0.302-alpine3.17-arm64v8, 7.0-alpine3.17-arm64v8, 7.0.302-alpine3.17, 7.0-alpine3.17, 7.0-alpine | [Dockerfile](https://github.com/dotnet/dotnet-docker/blob/nightly/src/sdk/7.0/alpine3.17/arm64v8/Dockerfile) | Alpine 3.17


Looks like the 7.0-alpine-arm64v8 tag was dropped.

tests/Microsoft.DotNet.Docker.Tests/TestData.cs

mthalman · 2023-05-22T13:34:17Z

eng/mcr-tags-metadata-templates/aspnet-tags.yml

    customSubTableTitle: .NET 8 Preview Tags
 $(McrTagsYmlTagGroup:7.0-bullseye-slim-amd64)
 $(McrTagsYmlTagGroup:7.0-alpine3.17-amd64)
+$(McrTagsYmlTagGroup:7.0-alpine3.18-amd64)


3.18 should be listed above 3.17. Applies in all instances.

This requires regenerating the readmes.

mthalman · 2023-05-22T13:50:19Z

Looks like there's a PowerShell failure in 6.0 that needs to be investigated. Seems consistent.

lbussell · 2023-05-22T17:45:33Z

@jander-msft, when do we want to move monitor to alpine3.18? Sometime after these are released and you have time to test it?

jander-msft · 2023-05-22T17:50:32Z

@jander-msft, when do we want to move monitor to alpine3.18? Sometime after these are released and you have time to test it?

It should move to 3.18 when the floating alpine tags are moved to 3.18

jander-msft · 2023-05-22T17:53:56Z

@jander-msft, when do we want to move monitor to alpine3.18? Sometime after these are released and you have time to test it?

It should move to 3.18 when the floating alpine tags are moved to 3.18

Completely separate from this effort to add the 3.18, I would like to somehow codify that .NET Monitor should move with the floating tags in the manifest and dockerfiles such that we don't have to think about it, but I haven't worked that out yet. We did briefly discuss this earlier this year, and it might require a new set of floating tags. I can log an issue about this where it can ideated before executing on it.

lbussell · 2023-05-22T23:54:22Z

The issue here looks similar to PowerShell/PowerShell#19679 but with a different type initializer: System.Management.Automation.TypeAccelerators vs. System.Management.Automation.PSVersionInfo.

System.InvalidOperationException : Failed to execute docker run --name 6.0-pwsh-133292649288916909 --rm  mcr.microsoft.com/dotnet/nightly/sdk:6.0-alpine3.18-amd64 pwsh -c (Get-Childitem env:DOTNET_RUNNING_IN_CONTAINER).Value
Exit code: 139
Standard Error: One or more errors occurred. (The type initializer for 'System.Management.Automation.TypeAccelerators' threw an exception.)
Process terminated. The type initializer for 'System.Management.Automation.PSObject' threw an exception.
at System.Environment.FailFast(System.String, System.Exception)
at Microsoft.PowerShell.UnmanagedPSEntry.Start(System.String[], Int32)
at Microsoft.PowerShell.ManagedPSEntry.Main(System.String[])
System.TypeInitializationException: The type initializer for 'System.Management.Automation.PSObject' threw an exception.
---> System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Management.Infrastructure, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'. The system cannot find the file specified.


File name: 'Microsoft.Management.Infrastructure, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'
--- End of inner exception stack trace ---
at System.Management.Automation.PSObject.get_Properties()
at System.Management.Automation.HostUtilities.GetDollarProfile(String allUsersAllHosts, String allUsersCurrentHost, String currentUserAllHosts, String currentUserCurrentHost)
at Microsoft.PowerShell.ConsoleHost.DoRunspaceInitialization(Boolean skipProfiles, String initialCommand, String configurationName, Collection1 initialCommandArgs)    at Microsoft.PowerShell.ConsoleHost.DoCreateRunspace(String initialCommand, Boolean skipProfiles, Boolean staMode, String configurationName, Collection1 initialCommandArgs)
at Microsoft.PowerShell.ConsoleHost.CreateRunspace(Object runspaceCreationArgs)
at Microsoft.PowerShell.ConsoleHost.DoRunspaceLoop(String initialCommand, Boolean skipProfiles, Collection`1 initialCommandArgs, Boolean staMode, String configurationName)
at Microsoft.PowerShell.ConsoleHost.Run(CommandLineParameterParser cpp, Boolean isPrestartWarned)
at Microsoft.PowerShell.ConsoleHost.Start(String bannerText, String helpText)
at Microsoft.PowerShell.UnmanagedPSEntry.Start(String[] args, Int32 argc)

lbussell · 2023-05-23T21:10:21Z

I think we'll need to wait on dotnet/runtime#86284 to flow through. It might already be in the nightly builds but since #4628 is blocked, I'm not sure yet.

There's also a full release checklist here: dotnet/core#8470

mthalman · 2023-05-23T21:25:04Z

It might already be in the nightly builds but since #4628 is blocked, I'm not sure yet.

Since this is 6.0, it wouldn't be there until the June servicing release.

lbussell · 2023-05-23T23:44:44Z

I filed PowerShell/PowerShell#19703.

Since this is 6.0, it wouldn't be there until the June servicing release.

What's the resolution then? If the RID is the solution (which it may or may not be) would we have to wait until July to ship Alpine3.18 for 6.0? Or just validate internally ahead of time?

mthalman · 2023-05-24T13:16:57Z

What's the resolution then? If the RID is the solution (which it may or may not be) would we have to wait until July to ship Alpine3.18 for 6.0? Or just validate internally ahead of time?

Assuming the RID fixes the issue, then yes, we'd have to wait until July. We should be able to validate that in our internal branch now.

lbussell · 2023-05-25T04:41:05Z

An internal test run validated that the RID addition solves the PowerShell issue: https://dev.azure.com/dnceng/internal/_build/results?buildId=2187733&view=results (internal MSFT link)

tvbishan · 2023-05-30T03:46:35Z

@lbussell @mthalman So, we have to wait until July to receive Alpine 3.18 for 6.0?

mthalman · 2023-05-30T14:13:21Z

@lbussell @mthalman So, we have to wait until July to receive Alpine 3.18 for 6.0?

That hasn't been determined yet.

mthalman · 2023-05-31T19:57:06Z

tests/Microsoft.DotNet.Docker.Tests/SdkImageTests.cs

+                    reason = "PowerShell does not have Alpine arm images, skip testing";
+                    return false;
+                }
+                else if (imageData.OS.Contains("3.18"))


We should constrain this further since it's working on everything except for 6.0.

Suggested change

else if (imageData.OS.Contains("3.18"))

else if (imageData.Version.Major == 6 && imageData.OS.Contains("3.18"))

mthalman · 2023-05-31T20:01:07Z

tests/Microsoft.DotNet.Docker.Tests/SdkImageTests.cs

+                else if (imageData.OS.Contains("3.18"))
+                {
+                    // PowerShell does not support Alpine 3.18 yet (https://github.com/PowerShell/PowerShell/issues/19703)
+                    reason = "Powershell does not support Alpine 3.18 yet, skip testing"


Suggested change

reason = "Powershell does not support Alpine 3.18 yet, skip testing"

reason = "Powershell does not support Alpine 3.18 yet, skip testing";

mthalman

Looks like the Dockerfiles need to be regenerated.

lbussell requested a review from a team as a code owner May 19, 2023 20:57

ghost added area-dockerfiles Concerns the official .NET Dockerfiles or Dockerfile templates untriaged labels May 19, 2023

lbussell force-pushed the alpine3.18 branch from d1bb8b8 to a9ea495 Compare May 20, 2023 00:04

amirschw mentioned this pull request May 22, 2023

CVE-2023-1255 in alpine 3.17 base images tomkerkhove/promitor#2308

Closed

MichaelSimons reviewed May 22, 2023

View reviewed changes

mthalman reviewed May 22, 2023

View reviewed changes

lbussell force-pushed the alpine3.18 branch 2 times, most recently from aa820f1 to 87b56a0 Compare May 22, 2023 21:26

lbussell force-pushed the alpine3.18 branch from 87b56a0 to f2b733f Compare May 23, 2023 22:41

lbussell force-pushed the alpine3.18 branch from f2b733f to 884f970 Compare May 31, 2023 19:53

mthalman reviewed May 31, 2023

View reviewed changes

mthalman approved these changes Jun 1, 2023

View reviewed changes

mthalman requested a review from MichaelSimons June 1, 2023 14:11

lbussell added 2 commits June 1, 2023 14:00

Add Dockerfiles for alpine3.18

ff48d23

Skip PowerShell tests on 3.18

f082ecc

Fixes from code review

813a401

lbussell force-pushed the alpine3.18 branch from f47db5c to 813a401 Compare June 1, 2023 21:04

MichaelSimons approved these changes Jun 1, 2023

View reviewed changes

lbussell merged commit f61e4e5 into dotnet:nightly Jun 1, 2023

lbussell added a commit to lbussell/dotnet-docker that referenced this pull request Jun 9, 2023

Add Dockerfiles for alpine3.18 (dotnet#4629)

c4b5607

lbussell mentioned this pull request Jun 14, 2023

Move dotnet-monitor and Alpine floating tags to 3.18 #4669

Merged

lbussell added a commit to lbussell/dotnet-docker that referenced this pull request Jul 10, 2023

Add missing test for alpine3.18 6.0 powershell (dotnet#4629)

9707348

lbussell mentioned this pull request Aug 7, 2023

Remove Alpine 3.17 Dockerfiles #4797

Closed

	else if (imageData.OS.Contains("3.18"))
	else if (imageData.Version.Major == 6 && imageData.OS.Contains("3.18"))

	reason = "Powershell does not support Alpine 3.18 yet, skip testing"
	reason = "Powershell does not support Alpine 3.18 yet, skip testing";

Add Dockerfiles for alpine3.18 #4629

Add Dockerfiles for alpine3.18 #4629

Uh oh!

Conversation

lbussell commented May 19, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mthalman commented May 22, 2023

Uh oh!

lbussell commented May 22, 2023

Uh oh!

jander-msft commented May 22, 2023

Uh oh!

jander-msft commented May 22, 2023

Uh oh!

lbussell commented May 22, 2023

Uh oh!

lbussell commented May 23, 2023

Uh oh!

mthalman commented May 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lbussell commented May 23, 2023

Uh oh!

mthalman commented May 24, 2023

Uh oh!

lbussell commented May 25, 2023

Uh oh!

tvbishan commented May 30, 2023

Uh oh!

mthalman commented May 30, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mthalman left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mthalman commented May 23, 2023 •

edited

Loading