Move dotnet-monitor and Alpine floating tags to 3.18 #4669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
area-dockerfiles
mthalman
reviewed
Jun 15, 2023
| "dockerfileTemplate": "eng/dockerfile-templates/monitor/Dockerfile.linux", | ||
| "os": "linux", | ||
| "osVersion": "alpine3.17", | ||
| "osVersion": "alpine3.18", |
Member
There was a problem hiding this comment.
With the change in Alpine version for Monitor, the TestData.cs file needs to be updated to reflect this change as well. Currently the Monitor test data is referencing OS.Alpine317.
mthalman
approved these changes
Jun 15, 2023
jander-msft
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4663
Per #4629 (comment) I have also moved .NET monitor to Alpine 3.18.