Skip to content

Conversation

@jasonmalinowski
Copy link
Member

@jasonmalinowski jasonmalinowski commented Nov 30, 2017

This carries along some breaking changes (dotnet/roslyn@efd59a3) in Roslyn's Quick Info implementation that we must react to. Since it's our first move to the 2.6 line it also carries along some deprecation of some APIs (namely, classification and comment handling) that we also respond to as well.

Copy link
Member

@brettfo brettfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming Ctrl+K, C, Ctrl+K, U, classification, and quick info work, :shipit:.

@brettfo
Copy link
Member

brettfo commented Nov 30, 2017

From the Jenkins log:

"D:\j\w\release_ci_pa---5a4853ab\vsintegration\tests\unittests\VisualFSharp.Unittests.fsproj" (Build target) (45) ->
(CoreCompile target) -> 
  D:\j\w\release_ci_pa---5a4853ab\vsintegration\tests\unittests\TestLib.LanguageService.fs(368,17): error FS0074: The type referenced through 'Microsoft.CodeAnalysis.Editor.QuickInfo.DeferredContentFrameworkElementFactory' is defined in an assembly that is not referenced. You must add a reference to assembly 'Microsoft.CodeAnalysis.EditorFeatures.Wpf'. [D:\j\w\release_ci_pa---5a4853ab\vsintegration\tests\unittests\VisualFSharp.Unittests.fsproj]

@jasonmalinowski
Copy link
Member Author

@brettfo I find your lack of PackageReferences disturbing.

This carries along some breaking changes
(dotnet/roslyn@efd59a3) in Roslyn's
Quick Info implementation that we must react to. Since it's our first
move to the 2.6 line it also carries along some deprecation of some APIs
(namely, classification and comment handling) that we also respond to
as well.
@jasonmalinowski jasonmalinowski force-pushed the move-to-new-roslyn-packages branch from b0fa534 to 1e7ffd1 Compare November 30, 2017 00:40
@jasonmalinowski jasonmalinowski self-assigned this Nov 30, 2017
@brettfo
Copy link
Member

brettfo commented Nov 30, 2017

Adding @KevinRansom as an FYI. I've also turned off all auto-merges into and out of dev15.6 since we'll need to be more deliberate now.

@brettfo brettfo merged commit 8c65e33 into dotnet:dev15.6 Nov 30, 2017
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
…n-packages

Move F# to consume Roslyn 2.6.0-vs-for-mac-62317-08
<package id="Microsoft.CodeAnalysis.Common" version="2.6.0-vs-for-mac-62329-05" targetFramework="net46" />
<package id="Microsoft.CodeAnalysis.EditorFeatures" version="2.6.0-vs-for-mac-62329-05" targetFramework="net46" />
<package id="Microsoft.CodeAnalysis.EditorFeatures.Text" version="2.6.0-vs-for-mac-62329-05" targetFramework="net46" />
<package id="Microsoft.CodeAnalysis.EditorFeatures.Wpf" version="2.6.0-vs-for-mac-62329-05" targetFramework="net46" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasonmalinowski :

Hi Jason, is the EditorFeatures.Wpf package still relevant in any way?
I am in the process of darc-ifiying our Roslyn dependencies (to spot issues earlier than when things are bound in VS) and I noticed this Microsoft.CodeAnalysis.EditorFeatures.Wpf has not been updated in years.

Which lead to me to this PR which added it despite not being used in the code....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It no longer exists. EditorFeatures vs. EditorFeatures.Wpf existed as a split when we had to also support VS for Mac and it's Cocoa-based editor, but that's no longer supported so we've merged the two packages back together again.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is lovely to hear, this package was source of manning NUGET conflict warnings I had to resolve.

Happy to remove and will see if I can in cascade also remove a lot of transient package references we did need to have in order to guide nuget around version mismatches 👍

@jasonmalinowski jasonmalinowski deleted the move-to-new-roslyn-packages branch October 2, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants