-
Notifications
You must be signed in to change notification settings - Fork 844
Move F# to consume Roslyn 2.6.0-vs-for-mac-62317-08 #4037
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move F# to consume Roslyn 2.6.0-vs-for-mac-62317-08 #4037
Conversation
brettfo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming Ctrl+K, C, Ctrl+K, U, classification, and quick info work,
.
|
From the Jenkins log: |
|
@brettfo I find your lack of PackageReferences disturbing. |
This carries along some breaking changes (dotnet/roslyn@efd59a3) in Roslyn's Quick Info implementation that we must react to. Since it's our first move to the 2.6 line it also carries along some deprecation of some APIs (namely, classification and comment handling) that we also respond to as well.
b0fa534 to
1e7ffd1
Compare
|
Adding @KevinRansom as an FYI. I've also turned off all auto-merges into and out of |
…n-packages Move F# to consume Roslyn 2.6.0-vs-for-mac-62317-08
| <package id="Microsoft.CodeAnalysis.Common" version="2.6.0-vs-for-mac-62329-05" targetFramework="net46" /> | ||
| <package id="Microsoft.CodeAnalysis.EditorFeatures" version="2.6.0-vs-for-mac-62329-05" targetFramework="net46" /> | ||
| <package id="Microsoft.CodeAnalysis.EditorFeatures.Text" version="2.6.0-vs-for-mac-62329-05" targetFramework="net46" /> | ||
| <package id="Microsoft.CodeAnalysis.EditorFeatures.Wpf" version="2.6.0-vs-for-mac-62329-05" targetFramework="net46" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jason, is the EditorFeatures.Wpf package still relevant in any way?
I am in the process of darc-ifiying our Roslyn dependencies (to spot issues earlier than when things are bound in VS) and I noticed this Microsoft.CodeAnalysis.EditorFeatures.Wpf has not been updated in years.
Which lead to me to this PR which added it despite not being used in the code....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It no longer exists. EditorFeatures vs. EditorFeatures.Wpf existed as a split when we had to also support VS for Mac and it's Cocoa-based editor, but that's no longer supported so we've merged the two packages back together again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is lovely to hear, this package was source of manning NUGET conflict warnings I had to resolve.
Happy to remove and will see if I can in cascade also remove a lot of transient package references we did need to have in order to guide nuget around version mismatches 👍
This carries along some breaking changes (dotnet/roslyn@efd59a3) in Roslyn's Quick Info implementation that we must react to. Since it's our first move to the 2.6 line it also carries along some deprecation of some APIs (namely, classification and comment handling) that we also respond to as well.