fix diagnostic priorities (dev 15.7)

[dsyme]

No description provided.

[dsyme]

I presume this is failing because we need to update roslyn version numbers

[dsyme]

Yes, we need a roslyn version number update for the new code in 15.7

  D:\j\w\release_ci_pa---c11de9d5\vsintegration\src\FSharp.Editor\Diagnostics\DocumentDiagnosticAnalyzer.fs(107,17): error FS0859: No abstract property was found that corresponds to this override [D:\j\w\release_ci_pa---c11de9d5\vsintegration\src\FSharp.Editor\FSharp.Editor.fsproj]
  D:\j\w\release_ci_pa---c11de9d5\vsintegration\src\FSharp.Editor\Diagnostics\SimplifyNameDiagnosticAnalyzer.fs(45,17): error FS0859: No abstract property was found that corresponds to this override [D:\j\w\release_ci_pa---c11de9d5\vsintegration\src\FSharp.Editor\FSharp.Editor.fsproj]
  D:\j\w\release_ci_pa---c11de9d5\vsintegration\src\FSharp.Editor\Diagnostics\UnusedDeclarationsAnalyzer.fs(97,17): error FS0859: No abstract property was found that corresponds to this override [D:\j\w\release_ci_pa---c11de9d5\vsintegration\src\FSharp.Editor\FSharp.Editor.fsproj]
  D:\j\w\release_ci_pa---c11de9d5\vsintegration\src\FSharp.Editor\Diagnostics\UnusedOpensDiagnosticAnalyzer.fs(38,17): error FS0859: No abstract property was found that corresponds to this override [D:\j\w\release_ci_pa---c11de9d5\vsintegration\src\FSharp.Editor\FSharp.Editor.fsproj]

[dsyme]

@dotnet-bot test this please

[dsyme]

@brettfo Do you know if the the Roslyn binaries have been updated?

[cartermp]

@jasonmalinowski Should know as well.

[brettfo]

There were API changes in dev15.6 via #4037, but those changes have been in dev15.7 for a few weeks (maybe months) now.

[dsyme]

@brettfo There should be API changes coming in 15.7, corresponding to dotnet/roslyn#24673. We don't seem to have those yet

We really want to get this in for 15.7 if possible :) thanks

[brettfo]

I see, I was thinking of a different Roslyn change.

To consume these APIs you'll need to:

1. Update the last line of NuGet.config:

-https://dotnet.myget.org/F/roslyn-for-vs-for-mac/api/v3/index.json
+https://dotnet.myget.org/F/roslyn/api/v3/index.json

2. Update RoslynPackageVersion.txt to a version from here that starts with 2.7.0-beta3-* that was created after added a way to specify ordering of Document/ProjectDiagnosticAnalyzers roslyn#24673 was merged, so probably any of the versions after Feb 13.

[dsyme]

@brettfo I tried 2.7.0-beta3-62707-11 but the Priority abstract member wasn't there

It is present in 2.8.0-beta2-62713-01, but there is one other change there in the signature of QuickInfoDisplayDeferredContent (easy to fix, but an API change)

Can we use 2.8.0-beta2-62713-01? Indeed should we if there has been an API change?

thanks

[brettfo]

@dsyme I just checked today's build of the 15.7 preview (which version we can't exceed) and it's on 2.8.0-beta1-62707-12, so we should choose something <= to that, still in the 2.8.0-beta1-* train.

[dsyme]

@brettfo OK, changed to that version. I also fixed the PR so it is only pushing the diff, not stuff from master

[brettfo]

You should also update the last line of NuGet.config:

-https://dotnet.myget.org/F/roslyn-for-vs-for-mac/api/v3/index.json
+https://dotnet.myget.org/F/roslyn/api/v3/index.json

The roslyn-for-vs-for-mac feed was added as a temporary stop-gap that Roslyn will eventually remove, but the roslyn feed will exist until the end of time.

[dsyme]

@brettfo Done - this is ready. Will you merge back to master too? (when 15.7 is released)

[brettfo]

Yes. When Dev15.7 RTM ships this branch will come back into master.

[cartermp]

WEW that was scary, since the green button in the GitHub UI said "commit merge"