Turn off unused opens diagnostic analyzer in dev15.6 #4494
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The problem is that this will have to meet a servicing bar, i.e. demonstrably break customers in some way that they weren't before, or severely degrade their experience from the previous release such that this new one is unworkable. Given that there is already a workaround to turn it off, I suspect this does not meet that bar. |
dsyme
changed the title
Contributor
Author
|
@dotnet-bot test Ubuntu14.04 Release_fcs Build please |
1 similar comment
Contributor
Author
|
@dotnet-bot test Ubuntu14.04 Release_fcs Build please |
Contributor
Author
|
@cartermp Re servicing bar - I'll leave you to decide. It's the first thing I noticed when using 15.6 "as a customer". I suspect it wasn't in 15.3/15.4, but I don't have proof of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed patch to dev15.6. See #4488
This diagnostic analyzer can be re-enabled once
(a) the analyzers run in priority order, see #4341
(b) the underlying code for unused opens is made performant, see #4488 and fsharp/fsharp-compiler-docs#830
(c) the underlying code for unused opens is made cancellable