[roslyn update needed] set diagnostic analyzer priorities #4341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
changed the title
Contributor
Author
|
The roslyn update has been approved for merge to 15.7 dotnet/roslyn#24673 |
cartermp
suggested changes
Feb 12, 2018
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Can we move each of the integer literals to values in Common/Constants.fs?
Love this change for 15.7
Contributor
Author
|
Note the failures are due to roslyn version Re one file - yes, np. (I'm on the train if I forget can the person who eventually accepts this do this please) |
saul
reviewed
Feb 18, 2018
| return results | ||
| } | ||
|
|
||
| override __.Priority = 10 // Default = 50 |
Contributor
There was a problem hiding this comment.
I think we should make this 0, as that is the highest priority available. (In Roslyn, compiler is -2 and 'regular diagnostics' are -1.)
Contributor
|
@dsyme can you retarget since the Roslyn fix went in for 15.7? We'll merge that back into master once it ships. |
Contributor
Author
|
See #4369, closing this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets document diagnostic analyzer error priorities.
Can be integrated when dotnet/roslyn#24673 is available in Roslyn
NOTE: Should NOT be integrated into the nightly update branch until we know we can rely on the binaries above being available
This doesn't yet turn SimplifyName on by default