Remove --simpleresolution from other flags #6193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIHan
approved these changes
Feb 5, 2019
This reverts commit d12c0fe.
Contributor
|
There is one failure in CI now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current NetSDK targets sets the otherflags to contain --simpleresolution. NetSDK projects must always have this flag set. The coreclr compiler only allows it to be true. The desktop compiler, allows it to be true or false and defaults to false.
Anyway, we don't really want to expose this on our properties page. So we have added a property in the targets file, which allows us to surface other flags as empty by default.
/cc @TIHan