Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert "Remove --simpleresolution from other flags"
This reverts commit d12c0fe.
  • Loading branch information
KevinRansom committed Feb 5, 2019
commit b543c55f205b99a4edb27b961593349e7f709e2c
2 changes: 1 addition & 1 deletion FSharp.Profiles.props
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
<DefineConstants>$(DefineConstants);FX_RESHAPED_GLOBALIZATION</DefineConstants>
<DefineConstants>$(DefineConstants);FX_RESHAPED_REFLECTION</DefineConstants>
<DefineConstants>$(DefineConstants);FX_RESHAPED_MSBUILD</DefineConstants>
<OtherFlags Condition="'$(SimpleResolution)' == ''">$(OtherFlags) --simpleresolution</OtherFlags>
<OtherFlags>$(OtherFlags) --simpleresolution</OtherFlags>
</PropertyGroup>

</Project>
9 changes: 0 additions & 9 deletions src/fsharp/FSharp.Build/Fsc.fs
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ type public Fsc () as this =
let mutable references : ITaskItem[] = [||]
let mutable referencePath : string = null
let mutable resources : ITaskItem[] = [||]
let mutable simpleResolution:bool = false
let mutable skipCompilerExecution : bool = false
let mutable sources : ITaskItem[] = [||]
let mutable sourceLink : string = null
Expand Down Expand Up @@ -157,7 +156,6 @@ type public Fsc () as this =

// VersionFile
builder.AppendSwitchIfNotNull("--versionfile:", versionFile)

// References
if references <> null then
for item in references do
Expand Down Expand Up @@ -240,9 +238,6 @@ type public Fsc () as this =

builder.AppendSwitch("--nocopyfsharpcore")

// SimpleResolution
if simpleResolution then builder.AppendSwitch("--simpleresolution")

// OtherFlags - must be second-to-last
builder.AppendSwitchUnquotedIfNotNull("", otherFlags)
capturedArguments <- builder.CapturedArguments()
Expand Down Expand Up @@ -399,10 +394,6 @@ type public Fsc () as this =
with get() = resources
and set(a) = resources <- a

member fsc.SimpleResolution
with get() = simpleResolution
and set(p) = simpleResolution <- p

member fsc.SkipCompilerExecution
with get() = skipCompilerExecution
and set(p) = skipCompilerExecution <- p
Expand Down
1 change: 0 additions & 1 deletion src/fsharp/FSharp.Build/Microsoft.FSharp.NetSdk.props
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and
<WarningLevel Condition=" '$(WarningLevel)' == '' ">3</WarningLevel>
<WarningsAsErrors>3239;$(WarningsAsErrors)</WarningsAsErrors>
<UseStandardResourceNames Condition=" '$(UseStandardResourceNames)' == '' ">true</UseStandardResourceNames>
<SimpleResolution Condition=" '$(SimpleResolution)' == '' ">true</SimpleResolution>
<FsiExec Condition=" '$(FsiExec)' == '' ">true</FsiExec>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/fsharp/FSharp.Build/Microsoft.FSharp.NetSdk.targets
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ WARNING: DO NOT MODIFY this file unless you are knowledgeable about MSBuild and
<TargetProfile Condition=" '$(TargetFrameworkIdentifier)' == '.NETFramework' " >mscorlib</TargetProfile>
<TargetProfile Condition=" '$(TargetFrameworkIdentifier)' != '.NETFramework' " >netcore</TargetProfile>
<TargetProfile Condition=" '$(TargetFrameworkIdentifier)' == '.NETStandard' and '$(_TargetFrameworkVersionWithoutV)' >= '2.0' " >netstandard</TargetProfile>
<OtherFlags>$(OtherFlags) --simpleresolution</OtherFlags>
</PropertyGroup>

<Import Project="Microsoft.FSharp.Targets" />
Expand Down
1 change: 0 additions & 1 deletion src/fsharp/FSharp.Build/Microsoft.FSharp.Targets
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,6 @@ this file.
References="@(ReferencePath)"
ReferencePath="$(ReferencePath)"
Resources="@(ActualEmbeddedResources)"
SimpleResolution="$(SimpleResolution)"
SkipCompilerExecution="$(SkipCompilerExecution)"
SourceLink="$(SourceLink)"
Sources="@(CompileBefore);@(Compile);@(CompileAfter)"
Expand Down