-
Notifications
You must be signed in to change notification settings - Fork 839
split service.fs #6247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split service.fs #6247
Conversation
|
@cartermp Same test failed:
|
|
Two remaining test failures, I can't tell if it's transient - both TypeProvider disposal smoke tests failed. I'll re-run tests. |
|
@dsyme is this still WIP? |
|
Also it seems like a good opportunity to normalize more whitespace here (e.g., line breaks) |
I'll do in a separate PR - this PR is splitting a large file in half which is a bit annoying as git loses the source history tracking with the half of the file moved into the new file. In case we ever needed it I created couple of branches that first duplicate "service.fs" and "service.fsi" into "FSharpCheckerResults.fs" and "FSharpCheckerResults.fsi" and then applies this diff, dsyme/fsharp@tmp2...clean5b That's a more realistic view of the changes in this PR |
|
@TIHan This is ready. Could you review? This may be better for review: dsyme/fsharp@tmp2...clean5b |
|
Unexpected unrelated failure in |
|
Looks like the failure from "visualfsharp-CI — #20190424.3 failed" is fake, a left over from our old build web hook, now replaced. Not sure how to clear that short of opening a new PR. |
|
@TIHan Can you approve? I'd like to get this in (it is a PITA to maintain :) ) |
|
@TIHan I'd like to keep working on pulling apart some of the monolithic files, I think it will help |
| @@ -0,0 +1,662 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (fsproj file) shouldn't be here as buildfromsource is gone from master.
TIHan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me. We simply just refactored out the checker results into a separate file.
One comment on the fsproj in buildfromsource. Basically that fsproj should be removed.
This is a spike of a cleanup to split service.fs into
FSharpCheckerResults.fs/fsiFSharpChecker.fs/fsialong with a little rejigging to make the abstraction boundary cleaner (in particular TypeCheckInfo is completely internal to the former)
There's about 2000 LOC in the former and 1200 LOC in the latter.
This work would conflict with changes in dev16.0 and I think should probably just go into that branch (I guess I'd do the work to do the merge, or redo the work completely)