reduce diff

fcs/FSharp.Compiler.Service/FSharp.Compiler.Service.fsproj

@@ -609,11 +609,11 @@
     <Compile Include="$(FSharpSourcesRoot)\fsharp\service\FSharpCheckerResults.fs">
       <Link>Service/FSharpCheckerResults.fs</Link>
     </Compile>
-    <Compile Include="$(FSharpSourcesRoot)\fsharp\service\FSharpChecker.fsi">
-      <Link>Service/FSharpChecker.fsi</Link>
+    <Compile Include="$(FSharpSourcesRoot)\fsharp\service\service.fsi">
+      <Link>Service/service.fsi</Link>
     </Compile>
-    <Compile Include="$(FSharpSourcesRoot)\fsharp\service\FSharpChecker.fs">
-      <Link>Service/FSharpChecker.fs</Link>
+    <Compile Include="$(FSharpSourcesRoot)\fsharp\service\service.fs">
+      <Link>Service/service.fs</Link>
     </Compile>
     <Compile Include="$(FSharpSourcesRoot)\fsharp\service\ServiceInterfaceStubGenerator.fsi">
       <Link>Service/ServiceInterfaceStubGenerator.fsi</Link>

fcs/docsrc/content/caches.fsx

@@ -57,12 +57,12 @@ Low-Memory Condition
 -------
 
 Version 1.4.0.8 added a "maximum memory" limit specified by the `MaxMemory` property on FSharpChecker (in MB). If an FCS project operation
-is performed (see `CheckMaxMemoryReached` in `FSharpChecker.fs`) and `System.GC.GetTotalMemory(false)` reports a figure greater than this, then
+is performed (see `CheckMaxMemoryReached` in `service.fs`) and `System.GC.GetTotalMemory(false)` reports a figure greater than this, then
 the strong sizes of all FCS caches are reduced to either 0 or 1.  This happens for the remainder of the lifetime of the FSharpChecker object. 
 In practice this will still make tools like the Visual Studio F# Power Tools usable, but some operations like renaming across multiple 
 projects may take substantially longer.
 
-By default the maximum memory trigger is disabled, see `maxMBDefault` in `FSharpChecker.fs`. 
+By default the maximum memory trigger is disabled, see `maxMBDefault` in `service.fs`. 
 
 Reducing the FCS strong cache sizes does not guarantee there will be enough memory to continue operations - even holding one project 
 strongly may exceed a process memory budget. It just means FCS may hold less memory strongly.

fcs/docsrc/content/ja/untypedtree.fsx

@@ -88,7 +88,7 @@ let getUntypedTree (file, input) =
 `FSharpChecker` の詳細については
 [ APIドキュメント](../reference/microsoft-fsharp-compiler-sourcecodeservices-FSharpChecker.html)
 の他に、F# ソースコードのインラインコメントも参考になるでしょう
-( [`FSharpChecker.fsi` のソースコードを参照](https://github.com/fsharp/fsharp/blob/fsharp_31/src/fsharp/service/FSharpChecker.fsi) )。
+( [`service.fsi` のソースコードを参照](https://github.com/fsharp/fsharp/blob/fsharp_31/src/fsharp/service/service.fsi) )。
 
 ASTの走査
 ---------

fcs/docsrc/content/queue.fsx

@@ -19,7 +19,7 @@ To disable implicit background checking completely, set ``checker.ImplicitlyStar
 To change the time before background work starts, set ``checker.PauseBeforeBackgroundWork`` to the required number of milliseconds.
 
 Most calls to the FSharpChecker API enqueue an operation in the FSharpChecker compiler queue. These correspond to the 
-calls to EnqueueAndAwaitOpAsync in [FSharpChecker.fs](https://github.com/fsharp/FSharp.Compiler.Service/blob/master/src/fsharp/service/FSharpChecker.fs).
+calls to EnqueueAndAwaitOpAsync in [service.fs](https://github.com/fsharp/FSharp.Compiler.Service/blob/master/src/fsharp/service/service.fs).
 
 * For example, calling `ParseAndCheckProject` enqueues a `ParseAndCheckProjectImpl` operation. The time taken for the 
   operation will depend on how much work is required to bring the project analysis up-to-date.

src/buildfromsource/FSharp.Compiler.Private/FSharp.Compiler.Private.fsproj

@@ -584,11 +584,11 @@
     <Compile Include="..\..\fsharp\service\FSharpCheckerResults.fs">
       <Link>Service/FSharpCheckerResults.fs</Link>
     </Compile>
-    <Compile Include="..\..\fsharp\service\FSharpChecker.fsi">
-      <Link>Service/FSharpChecker.fsi</Link>
+    <Compile Include="..\..\fsharp\service\service.fsi">
+      <Link>Service/service.fsi</Link>
     </Compile>
-    <Compile Include="..\..\fsharp\service\FSharpChecker.fs">
-      <Link>Service/FSharpChecker.fs</Link>
+    <Compile Include="..\..\fsharp\service\service.fs">
+      <Link>Service/service.fs</Link>
     </Compile>
     <Compile Include="..\..\fsharp\service\ServiceInterfaceStubGenerator.fsi">
       <Link>Service/ServiceInterfaceStubGenerator.fsi</Link>

src/fsharp/AccessibilityLogic.fs

@@ -31,7 +31,7 @@ type AccessorDomain =
     /// This is used 
     ///    - when solving member trait constraints, which are solved independently of accessibility 
     ///    - for failure paths in error reporting, e.g. to produce an error that an F# item is not accessible
-    ///    - an adhoc use in FSharpChecker.fs to look up a delegate signature
+    ///    - an adhoc use in service.fs to look up a delegate signature
     | AccessibleFromSomeFSharpCode 
 
     /// An AccessorDomain which returns all items

src/fsharp/CompileOps.fs

@@ -1812,7 +1812,7 @@ let GetFsiLibraryName () = "FSharp.Compiler.Interactive.Settings"
 // This list is the default set of references for "non-project" files. 
 //
 // These DLLs are
-//    (a) included in the environment used for all .fsx files (see FSharpChecker.fs)
+//    (a) included in the environment used for all .fsx files (see service.fs)
 //    (b) included in environment for files 'orphaned' from a project context
 //            -- for orphaned files (files in VS without a project context)
 //            -- for files given on a command line without --noframework set
@@ -5254,7 +5254,7 @@ module private ScriptPreprocessClosure =
 
         result
 
-    /// Given source text, find the full load closure. Used from FSharpChecker.fs, when editing a script file
+    /// Given source text, find the full load closure. Used from service.fs, when editing a script file
     let GetFullClosureOfScriptText(ctok, legacyReferenceResolver, defaultFSharpBinariesDir, filename, source, codeContext, useSimpleResolution, useFsiAuxLib, lexResourceManager:Lexhelp.LexResourceManager, applyCommmandLineArgs, assumeDotNetFramework, tryGetMetadataSnapshot, reduceMemoryUsage) = 
         // Resolve the basic references such as FSharp.Core.dll first, before processing any #I directives in the script
         //

src/fsharp/CompileOptions.fs

@@ -1070,7 +1070,7 @@ let testingAndQAFlags _tcConfigB =
     The compiler options are put into blocks, named as <block>Flags.
     Some block options differ between fsc and fsi, in this case they split as <block>FlagsFsc and <block>FlagsFsi.
 
-    The "FSharpChecker.fs" (language service) flags are the same as the fsc flags (except help options are removed).
+    The "service.fs" (language service) flags are the same as the fsc flags (except help options are removed).
     REVIEW: is this correct? what about fsx files in VS and fsi options?
 
     Block                      | notes
@@ -1090,7 +1090,7 @@ let testingAndQAFlags _tcConfigB =
     ---------------------------|--------------------
 *)
 
-// Core compiler options exported to fsc.fs, FSharpChecker.fs and fsi.fs
+// Core compiler options exported to fsc.fs, service.fs and fsi.fs
 //----------------------------------------------------------------
 
 /// The core/common options used by fsc.exe. [not currently extended by fsc.fs].

src/fsharp/FSharp.Compiler.Private/FSharp.Compiler.Private.fsproj

@@ -625,11 +625,11 @@
     <Compile Include="..\..\fsharp\service\FSharpCheckerResults.fs">
       <Link>Service/FSharpCheckerResults.fs</Link>
     </Compile>
-    <Compile Include="..\service\FSharpChecker.fsi">
-      <Link>Service/FSharpChecker.fsi</Link>
+    <Compile Include="..\service\service.fsi">
+      <Link>Service/service.fsi</Link>
     </Compile>
-    <Compile Include="..\service\FSharpChecker.fs">
-      <Link>Service/FSharpChecker.fs</Link>
+    <Compile Include="..\service\service.fs">
+      <Link>Service/service.fs</Link>
     </Compile>
     <Compile Include="..\service\ServiceInterfaceStubGenerator.fsi">
       <Link>Service/ServiceInterfaceStubGenerator.fsi</Link>

src/fsharp/LexFilter.fs

@@ -441,7 +441,7 @@ type TokenTup =
 //--------------------------------------------------------------------------*)
 
 // Strip a bunch of leading '>' of a token, at the end of a typar application
-// Note: this is used in the 'FSharpChecker.fs' to do limited postprocessing
+// Note: this is used in the 'service.fs' to do limited postprocessing
 let (|TyparsCloseOp|_|) (txt:string) = 
     let angles = txt |> Seq.takeWhile (fun c -> c = '>') |> Seq.toList
     let afterAngles = txt |> Seq.skipWhile (fun c -> c = '>') |> Seq.toList

src/fsharp/symbols/SymbolHelpers.fs

@@ -111,7 +111,7 @@ type ErrorScope()  =
 
     member x.FirstError with get() = firstError and set v = firstError <- v
 
-    /// Used at entry points to FSharp.Compiler.Service (FSharpChecker.fsi) which manipulate symbols and
+    /// Used at entry points to FSharp.Compiler.Service (service.fsi) which manipulate symbols and
     /// perform other operations which might expose us to either bona-fide F# error messages such 
     /// "missing assembly" (for incomplete assembly reference sets), or, if there is a compiler bug, 
     /// may hit internal compiler failures.

src/fsharp/tast.fs

@@ -2799,7 +2799,7 @@ and [<NoEquality; NoComparison; StructuredFormatDisplay("{DebugText}")>]
     //   - in opt.fs   : when compiling fslib, we bind an entry for the value in a global table (see bind_escaping_local_vspec)
     //   - in ilxgen.fs: when compiling fslib, we bind an entry for the value in a global table (see bind_escaping_local_vspec)
     //   - in opt.fs   : (fullDebugTextOfValRef) for error reporting of non-inlinable values
-    //   - in FSharpChecker.fs (boutput_item_description): to display the full text of a value's binding location
+    //   - in service.fs (boutput_item_description): to display the full text of a value's binding location
     //   - in check.fs: as a boolean to detect public values for saving quotations 
     //   - in ilxgen.fs: as a boolean to detect public values for saving quotations 
     //   - in MakeExportRemapping, to build non-local references for values

src/utils/CompilerLocationUtils.fs

@@ -178,7 +178,7 @@ module internal FSharpEnvironment =
     // Used for
     //     - location of design-time copies of FSharp.Core.dll and FSharp.Compiler.Interactive.Settings.dll for the default assumed environment for scripts
     //     - default ToolPath in tasks in FSharp.Build.dll (for Fsc tasks, but note a probe location is given)
-    //     - default F# binaries directory in FSharpChecker.fs (REVIEW: check this)
+    //     - default F# binaries directory in service.fs (REVIEW: check this)
     //     - default location of fsi.exe in FSharp.VS.FSI.dll (REVIEW: check this)
     //     - default F# binaries directory in (project system) Project.fs
     let BinFolderOfDefaultFSharpCompiler(probePoint:string option) = 

vsintegration/Utils/LanguageServiceProfiling/Options.fs

@@ -189,8 +189,8 @@ let FCS (repositoryDir: string) : Options =
              @"src\fsharp\SimulatedMSBuildReferenceResolver.fs"
              @"src\fsharp\service\FSharpCheckerResults.fsi"
              @"src\fsharp\service\FSharpCheckerResults.fs"
-             @"src\fsharp\service\FSharpChecker.fsi"
-             @"src\fsharp\service\FSharpChecker.fs"
+             @"src\fsharp\service\service.fsi"
+             @"src\fsharp\service\service.fs"
              @"src\fsharp\service\SimpleServices.fsi"
              @"src\fsharp\service\SimpleServices.fs"
              @"src\fsharp\fsi\fsi.fsi"

vsintegration/tests/Salsa/salsa.fs

@@ -1159,7 +1159,7 @@ module internal Salsa =
 
             member file.DoIntellisenseRequest(parseReason) =
                 if parseReason = BackgroundRequestReason.MemberSelect then
-                    // In the actual product, the only thing that can trigger MemberSelect is the auto-popup caused by the "." or ".." tokens (see FSharpChecker.fs:TokenClassifications.tokenInfo)
+                    // In the actual product, the only thing that can trigger MemberSelect is the auto-popup caused by the "." or ".." tokens (see service.fs:TokenClassifications.tokenInfo)
                     // Thus, let's try to ensure that unit tests are only testing code paths from the actual product, and assert/fail if not.  Best effort.
                     let lineIndex, colIndex = cursor.line-1, cursor.col-1
                     System.Diagnostics.Debug.Assert(colIndex > 0, "hm, how did we invoke at start of line?")

vsintegration/tests/UnitTests/LegacyLanguageService/Tests.LanguageService.ParameterInfo.fs

@@ -885,7 +885,7 @@ type UsingMSBuild()  =
         Assert.IsTrue(info.IsSome, "expected parameter info")
         let info = info.Value
         AssertEqual("f1", info.GetName(0))
-        // note about (5,0): FSharpChecker.fs adds three lines of empty text to the end of every file, so it reports the location of 'end of file' as first the char, 3 lines past the last line of the file
+        // note about (5,0): service.fs adds three lines of empty text to the end of every file, so it reports the location of 'end of file' as first the char, 3 lines past the last line of the file
         AssertEqual([|(2,10);(2,12);(2,13);(3,0)|], info.GetNoteworthyParamInfoLocations())
 
     [<Test>]
@@ -907,7 +907,7 @@ type UsingMSBuild()  =
         Assert.IsTrue(info.IsSome, "expected parameter info")
         let info = info.Value
         AssertEqual("Foo", info.GetName(0))
-        // note about (4,0): FSharpChecker.fs adds three lines of empty text to the end of every file, so it reports the location of 'end of file' as first the char, 3 lines past the last line of the file
+        // note about (4,0): service.fs adds three lines of empty text to the end of every file, so it reports the location of 'end of file' as first the char, 3 lines past the last line of the file
         AssertEqual([|(1,14);(1,17);(1,18);(2,0)|], info.GetNoteworthyParamInfoLocations())
 
 
@@ -934,7 +934,7 @@ We really need to rewrite some code paths here to use the real parse tree rather
         // Note: no TakeCoffeeBreak(this.VS)
         let info = GetParameterInfoAtCursor file // this will fall back to using the name environment, which is stale, but sufficient to look up the call to 'f1'
         AssertEqual("Foo", info.GetName(0))
-        // note about (4,0): FSharpChecker.fs adds three lines of empty text to the end of every file, so it reports the location of 'end of file' as first the char, 3 lines past the last line of the file
+        // note about (4,0): service.fs adds three lines of empty text to the end of every file, so it reports the location of 'end of file' as first the char, 3 lines past the last line of the file
         AssertEqual([|(1,14);(1,21);(1,21);(4,0)|], info.GetNoteworthyParamInfoLocations())
 *)
 
@@ -972,7 +972,7 @@ We really need to rewrite some code paths here to use the real parse tree rather
             r.ToString(), locs)
         let testLines = testLinesAndLocs |> List.map fst
         let expectedLocs = testLinesAndLocs |> List.map snd |> List.collect id |> List.toArray 
-        // note: FSharpChecker.fs adds a new line character to the end of every file, so it reports the location of 'end of file' as first the char, 3 lines past the last line of the file
+        // note: service.fs adds a new line character to the end of every file, so it reports the location of 'end of file' as first the char, 3 lines past the last line of the file
         let expectedLocs = if defaultArg markAtEOF false then 
                                 Array.append expectedLocs [| (testLines.Length-1)+1, 0 |] 
                            else