-
Notifications
You must be signed in to change notification settings - Fork 839
reformat some huge lines #6249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reformat some huge lines #6249
Conversation
|
This is now ready |
|
+1200 lines is an improvement in this case :) |
|
Would appreciate an "approve" on this so we can just merge it, it's just code sanitization |
|
Test failure: |
|
Sounds good. Although I'm personally fine with merging, I just don't want @KevinRansom and @brettfo to have too much of a headache when we merge 16.0 -> master when VS 2019 is GA. |
|
MacOS test machine flaked out |
KevinRansom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long lines is just natures way of telling you to get a bigger monitor :-)
The lines in the F# compiler code are waaaaaaay too long. It's a huge problem for code readability, e.g. when searching the codebase and landing on column 250 of some file. The longest line in master is around 400 characters.
This PR reformats about 100 massive lines in the range 250-400 characters and a bunch of other lines in the "huge" category. After this the longest line in
src\fsharpis 250. (There are 460+ longer lines inabsilbut I haven't touched those yet).It also adds a script that checks line lengths, current output after this change is below. I've added some exceptions for big tables in TcGlobals and tast.fs.
fsi tests\scripts\longLines.fsx
Perhaps a good community goal to get maximum line length down to around 150 (my laptop shows about 150), which would mean reformatting about 1500 lines. It's likely some of these could be skipped.