Attempt to fix flaky test #6255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Well that didn't work: |
Contributor
Author
|
It could be that the tests are now being run using multiproc @brettfo Do you know if multiproc is being used for VisualFSharp.UnitTests? |
Contributor
Author
|
This is now ready |
Contributor
Author
|
Included as part of #6254 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the test in #6248 (comment)
There is actually a duplicate of this test in ProjectAnalysisTests.fs and it has this line. This missing line would explain why the test is flaky. If we see the one in ProjectAnalysisTests fail then there is some other cause.
I won't remove the duplicate just yet because PerfTests.fs is included in the Visual F# Unit Tests while ProjectAnalysisTests.fs is not (that said both are included in the FCS unit tests, so we are currently running the test 3 times....)
cc @cartermp