Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
31ee3a4
relax indentations
dsyme Mar 9, 2019
3fb2e72
fix baseline
dsyme Mar 9, 2019
d1b1389
add diagnostics
dsyme Mar 10, 2019
0f89711
add diagnostics
dsyme Mar 10, 2019
7da6aff
diagnostics
dsyme Mar 11, 2019
871489b
diagnostics
dsyme Mar 11, 2019
27d00a0
diagnostics
dsyme Mar 11, 2019
7d98d16
add diagnostics and possible fix for tp smoke tests
dsyme Mar 11, 2019
cc6e992
fix build
dsyme Mar 11, 2019
e13b385
fix build
dsyme Mar 11, 2019
8832b48
Merge branch 'diag4' into indents5
dsyme Mar 11, 2019
ce0961e
more diagnostics
dsyme Mar 11, 2019
2bb15ce
integrate master
dsyme Mar 11, 2019
5111d4e
Merge branch 'master' of http://github.com/Microsoft/visualfsharp int…
dsyme Mar 11, 2019
51e2012
try to fix flaky test
dsyme Mar 12, 2019
1b12929
Update neg77.fsx
dsyme Mar 12, 2019
26e05dd
fix build
dsyme Mar 12, 2019
434810a
try to fix dodgy test
dsyme Mar 13, 2019
71f51b9
Merge branch 'diag4' into indents5
dsyme Mar 13, 2019
cbd1cf9
Merge branch 'master' of http://github.com/Microsoft/visualfsharp int…
dsyme Mar 13, 2019
49ad748
Merge branch 'indents5' of https://github.com/dsyme/visualfsharp into…
dsyme Mar 13, 2019
9aad485
Merge branch 'master' of http://github.com/Microsoft/visualfsharp int…
dsyme Mar 20, 2019
c921eff
Merge branch 'master' of https://github.com/Microsoft/visualfsharp in…
dsyme Mar 21, 2019
c6b1c8c
merge master
dsyme Mar 26, 2019
7b00422
Merge branch 'master' of http://github.com/Microsoft/visualfsharp int…
dsyme Apr 1, 2019
44790ee
Merge branch 'master' of http://github.com/Microsoft/visualfsharp int…
dsyme Apr 14, 2019
7651e86
Merge branch 'master' of http://github.com/Microsoft/visualfsharp int…
dsyme Apr 16, 2019
705f5d8
Merge branch 'master' of http://github.com/Microsoft/visualfsharp int…
dsyme May 22, 2019
7c3b250
Merge pull request #6826 from dotnet/merges/master-to-feature/relax-i…
May 23, 2019
0325034
Fix unused opens false positive for record fields (#6846)
auduchinok May 24, 2019
4f50cd6
add CI leg to verify assemblies aren't unnecessarily being rebuilt (#…
brettfo May 24, 2019
25560f4
Removing option from Tuple active pattern (#6772)
fangyi-zhou May 24, 2019
d257c8f
Merge pull request #6839 from dotnet/merges/master-to-feature/relax-i…
May 24, 2019
73869ce
Merge pull request #6857 from dotnet/merges/master-to-feature/relax-i…
May 25, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add CI leg to verify assemblies aren't unnecessarily being rebuilt (#…
  • Loading branch information
brettfo authored May 24, 2019
commit 4f50cd6c771a6cd7f80c68a0a0571f2a34b4ffb1
13 changes: 13 additions & 0 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,19 @@ jobs:
- script: eng\CIBuild.cmd -configuration Release -noSign /p:DotNetBuildFromSource=true /p:FSharpSourceBuild=true
displayName: Build

# Up-to-date
- job: UpToDate_Windows
pool:
vmImage: windows-2019
steps:
- checkout: self
clean: true
- task: PowerShell@2
displayName: Run up-to-date build check
inputs:
filePath: eng\tests\UpToDate.ps1
arguments: -configuration $(_BuildConfig) -ci -binaryLog

#---------------------------------------------------------------------------------------------------------------------#
# FCS builds #
#---------------------------------------------------------------------------------------------------------------------#
Expand Down
70 changes: 70 additions & 0 deletions eng/tests/UpToDate.ps1
Original file line number Diff line number Diff line change
@@ -0,0 +1,70 @@
# This script verifies that subsequent calls to `Build.cmd` don't cause assemblies to be unnecessarily rebuilt.

[CmdletBinding(PositionalBinding=$false)]
param (
[string][Alias('c')]$configuration = "Debug",
[parameter(ValueFromRemainingArguments=$true)][string[]]$properties
)

Set-StrictMode -version 2.0
$ErrorActionPreference = "Stop"

try {
$RepoRoot = Join-Path $PSScriptRoot ".." | Join-Path -ChildPath ".." -Resolve
$BuildScript = Join-Path $RepoRoot "Build.cmd"

# do first build
& $BuildScript -configuration $configuration @properties
if ($LASTEXITCODE -ne 0) {
Write-Host "Error running first build."
exit 1
}

# gather assembly timestamps
$ArtifactsBinDir = Join-Path $RepoRoot "artifacts" | Join-Path -ChildPath "bin" -Resolve
$FSharpAssemblyDirs = Get-ChildItem -Path $ArtifactsBinDir -Filter "FSharp.*"
$FSharpAssemblyPaths = $FSharpAssemblyDirs | ForEach-Object { Get-ChildItem -Path (Join-Path $ArtifactsBinDir $_) -Recurse -Filter "$_.dll" } | ForEach-Object { $_.FullName }

$InitialAssembliesAndTimes = @{}
foreach ($asm in $FSharpAssemblyPaths) {
$LastWriteTime = (Get-Item $asm).LastWriteTimeUtc
$InitialAssembliesAndTimes.Add($asm, $LastWriteTime)
}

$InitialCompiledCount = $FSharpAssemblyPaths.Length

# build again
& $BuildScript -configuration $configuration @properties
if ($LASTEXITCODE -ne 0) {
Write-Host "Error running second build."
exit 1
}

# gather assembly timestamps again
$FinalAssembliesAndTimes = @{}
foreach ($asm in $FSharpAssemblyPaths) {
$LastWriteTime = (Get-Item $asm).LastWriteTimeUtc
$FinalAssembliesAndTimes.Add($asm, $LastWriteTime)
}

# validate that assembly timestamps haven't changed
$RecompiledFiles = @()
foreach ($asm in $InitialAssembliesAndTimes.keys) {
$InitialTime = $InitialAssembliesAndTimes[$asm]
$FinalTime = $FinalAssembliesAndTimes[$asm]
if ($InitialTime -ne $FinalTime) {
$RecompiledFiles += $asm
}
}

$RecompiledCount = $RecompiledFiles.Length
Write-Host "$RecompiledCount of $InitialCompiledCount assemblies were re-compiled"
$RecompiledFiles | ForEach-Object { Write-Host " $_" }
exit $RecompiledCount
}
catch {
Write-Host $_
Write-Host $_.Exception
Write-Host $_.ScriptStackTrace
exit 1
}