Skip to content

add CI leg to verify assemblies aren't unnecessarily being rebuilt #6816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brettfo merged 1 commit into from
May 24, 2019
Merged

add CI leg to verify assemblies aren't unnecessarily being rebuilt #6816

brettfo merged 1 commit into from
May 24, 2019

Conversation

@brettfo
Copy link
Member

@brettfo brettfo commented May 22, 2019

No description provided.

@brettfo brettfo requested a review from dsyme May 22, 2019 23:31
@brettfo brettfo force-pushed the up-to-date branch 2 times, most recently from bbe734c to 7c0affd Compare May 22, 2019 23:52
@brettfo
Copy link
Member Author

brettfo commented May 23, 2019

Up-to-date check passed in this run.

I have now temporarily reverted #6795 to see if it appropriately fails.

@brettfo brettfo changed the title add CI leg to verify assemblies aren't unnecessarily being rebuilt [WIP] add CI leg to verify assemblies aren't unnecessarily being rebuilt May 23, 2019
@brettfo
Copy link
Member Author

brettfo commented May 23, 2019

Revert of #6795 caused the expected failure:

19 of 28 assemblies were re-compiled
    D:\a\1\s\artifacts\bin\FSharp.VS.FSI\Release\net472\FSharp.VS.FSI.dll
    D:\a\1\s\artifacts\bin\FSharp.Build\Release\net472\FSharp.Build.dll
    D:\a\1\s\artifacts\bin\FSharp.Core\Release\netstandard1.6\FSharp.Core.dll
    D:\a\1\s\artifacts\bin\FSharp.Core\Release\net45\FSharp.Core.dll
    D:\a\1\s\artifacts\bin\FSharp.Compiler.Interactive.Settings\Release\netstandard2.0\FSharp.Compiler.Interactive.Settings.dll
    D:\a\1\s\artifacts\bin\FSharp.Core.UnitTests\Release\netcoreapp2.1\FSharp.Core.UnitTests.dll
    D:\a\1\s\artifacts\bin\FSharp.Editor\Release\net472\FSharp.Editor.dll
    D:\a\1\s\artifacts\bin\FSharp.Build.UnitTests\Release\netcoreapp2.1\FSharp.Build.UnitTests.dll
    D:\a\1\s\artifacts\bin\FSharp.LanguageService\Release\net472\FSharp.LanguageService.dll
    D:\a\1\s\artifacts\bin\FSharp.Compiler.UnitTests\Release\net472\FSharp.Compiler.UnitTests.dll
    D:\a\1\s\artifacts\bin\FSharp.LanguageService.Base\Release\net472\FSharp.LanguageService.Base.dll
    D:\a\1\s\artifacts\bin\FSharp.Core.UnitTests\Release\net472\FSharp.Core.UnitTests.dll
    D:\a\1\s\artifacts\bin\FSharp.Compiler.UnitTests\Release\netcoreapp2.1\FSharp.Compiler.UnitTests.dll
    D:\a\1\s\artifacts\bin\FSharp.Compiler.Private\Release\net472\FSharp.Compiler.Private.dll
    D:\a\1\s\artifacts\bin\FSharp.Build.UnitTests\Release\net472\FSharp.Build.UnitTests.dll
    D:\a\1\s\artifacts\bin\FSharp.Compiler.Private\Release\netstandard2.0\FSharp.Compiler.Private.dll
    D:\a\1\s\artifacts\bin\FSharp.Compiler.Server.Shared\Release\net472\FSharp.Compiler.Server.Shared.dll
    D:\a\1\s\artifacts\bin\FSharp.Build\Release\netcoreapp2.1\FSharp.Build.dll
    D:\a\1\s\artifacts\bin\FSharp.Compiler.Interactive.Settings\Release\net472\FSharp.Compiler.Interactive.Settings.dll

@brettfo brettfo changed the title [WIP] add CI leg to verify assemblies aren't unnecessarily being rebuilt add CI leg to verify assemblies aren't unnecessarily being rebuilt May 23, 2019
@brettfo brettfo merged commit 4f50cd6 into dotnet:master May 24, 2019
@brettfo brettfo deleted the up-to-date branch May 24, 2019 18:02
KevinRansom pushed a commit that referenced this pull request Jun 3, 2019
@dsyme @KevinRansom
[RFC FS-1070] relax indentations for static members and constructors (#…
dbd55ae 
…6808)

* relax indentations

* fix baseline

* add diagnostics

* add diagnostics

* diagnostics

* diagnostics

* diagnostics

* add diagnostics and possible fix for tp smoke tests

* fix build

* fix build

* more diagnostics

* try to fix flaky test

* Update neg77.fsx

* fix build

* try to fix dodgy test

* Fix unused opens false positive for record fields (#6846)

* Fix unused opens false positive for record fields

* Add record check

* add CI leg to verify assemblies aren't unnecessarily being rebuilt (#6816)

* Removing option from Tuple active pattern (#6772)
@dsyme
Copy link
Contributor

dsyme commented Jun 7, 2019

@brettfo Thank you thank you thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsyme dsyme Awaiting requested review from dsyme

1 more reviewer

@cartermp cartermp cartermp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brettfo @dsyme @cartermp