Fix unused opens false positive for record fields #6846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
approved these changes
May 24, 2019
TIHan
approved these changes
May 24, 2019
KevinRansom
pushed a commit
that referenced
this pull request
Jun 3, 2019
…6808) * relax indentations * fix baseline * add diagnostics * add diagnostics * diagnostics * diagnostics * diagnostics * add diagnostics and possible fix for tp smoke tests * fix build * fix build * more diagnostics * try to fix flaky test * Update neg77.fsx * fix build * try to fix dodgy test * Fix unused opens false positive for record fields (#6846) * Fix unused opens false positive for record fields * Add record check * add CI leg to verify assemblies aren't unnecessarily being rebuilt (#6816) * Removing option from Tuple active pattern (#6772)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Unused Open analysis false positive for cases where a record field is used for type inference.