No IVTs for CodeLenses #6906
Merged
No IVTs for CodeLenses #6906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
commented
May 30, 2019
| match func.FullTypeSafe with | ||
| | Some _ -> | ||
| let! displayEnv = checkFileResults.GetDisplayEnvForPos func.DeclarationLocation.Start | ||
| let! maybeContext = checkFileResults.GetDisplayContextForPos(func.DeclarationLocation.Start) |
Contributor
Author
There was a problem hiding this comment.
This is the call site change
…erenceResolver I'm not touching MSBuildReferenceResolver
KevinRansom
reviewed
May 31, 2019
Contributor
KevinRansom
left a comment
KevinRansom
left a comment
There was a problem hiding this comment.
couple of small things.
vsintegration/src/FSharp.Editor/CodeLens/AbstractCodeLensDisplayService.fs
Outdated
Show resolved
Hide resolved
Contributor
|
There is also the idea of ifdeffing the whole try/catch thing and just
don't catching at this level
Kevin Ransom (msft) <[email protected]> schrieb am Fr., 31. Mai
2019, 20:20:
… ***@***.**** commented on this pull request.
------------------------------
In
vsintegration/src/FSharp.Editor/CodeLens/AbstractCodeLensDisplayService.fs
<#6906 (comment)>:
> logExceptionWithContext(e, "Removing line lens")
+#endif
+ e |> ignore
+ ()
name it _e
or write it as ignore e then the e |>ignore makes me think the side
effects, of which there can be none are important.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#6906?email_source=notifications&email_token=AAAOANB5RUMNHSS5CCAQIU3PYFT7NA5CNFSM4HRKBFV2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2JA5KI#discussion_r289501157>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAOANCIQWPSWWLALFSMDRTPYFT7NANCNFSM4HRKBFVQ>
.
|
Contributor
Author
|
@forki That might work for a few cases, but in others it's necessary to |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
* Don't expose Legacy MSBuildReferenceResolver * Move the files boss hoss * Remove unused opens * Fix tests * Remove IVT dependency for CodeLens and put logging behind a flag * oopsie doopsie * meep morp * blub glub * heepers jeepers * Update fsi.fs * Update service.fs * Update service.fsi * Update FSharpCheckerProvider.fs * Update FSharpLanguageServiceTestable.fs * Update TestLib.LanguageService.fs * Updates for build in release * I'm not touching MSBuildReferenceResolver I'm not touching MSBuildReferenceResolver I'm not touching MSBuildReferenceResolver * Different ignore and adjust ifdefs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes IVT dependencies for CodeLens: