Skip to content

No IVTs for CodeLenses #6906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinRansom merged 18 commits into from
Jun 2, 2019
Merged

No IVTs for CodeLenses #6906

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
05d4bfd
Don't expose Legacy MSBuildReferenceResolver
cartermp May 29, 2019
6d46079
Move the files boss hoss
cartermp May 29, 2019
c020c2e
Remove unused opens
cartermp May 29, 2019
6e084c1
Fix tests
cartermp May 29, 2019
7fec0e9
Remove IVT dependency for CodeLens and put logging behind a flag
cartermp May 30, 2019
c5b0176
oopsie doopsie
cartermp May 30, 2019
84c7b14
meep morp
cartermp May 30, 2019
a1a192c
blub glub
cartermp May 30, 2019
1efc038
heepers jeepers
cartermp May 30, 2019
273807b
Update fsi.fs
cartermp May 30, 2019
58cf3b0
Update service.fs
cartermp May 30, 2019
8e17217
Update service.fsi
cartermp May 30, 2019
091ab58
Update FSharpCheckerProvider.fs
cartermp May 30, 2019
eb47ea9
Update FSharpLanguageServiceTestable.fs
cartermp May 30, 2019
429a349
Update TestLib.LanguageService.fs
cartermp May 30, 2019
644c44a
Updates for build in release
cartermp May 30, 2019
2036640
I'm not touching MSBuildReferenceResolver I'm not touching MSBuildRef…
cartermp May 31, 2019
c803dc4
Different ignore and adjust ifdefs
cartermp May 31, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
@cartermp
cartermp committed May 29, 2019
commit 6e084c1f8773914b074c89abbb0e8303751f6888
2 changes: 1 addition & 1 deletion src/fsharp/FSharp.Compiler.Private/FSharp.Compiler.Private.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
<InternalsVisibleTo Include="VisualFSharp.Salsa" />
<InternalsVisibleTo Include="VisualFSharp.UnitTests" />
<InternalsVisibleTo Include="FSharp.Compiler.UnitTests" />
<InternalsVisibleTo Include="FSharp.Editor" />
<!--<InternalsVisibleTo Include="FSharp.Editor" />-->
<InternalsVisibleTo Include="HostedCompilerServer" />
<InternalsVisibleTo Include="FSharp.Tests.FSharpSuite" />
<InternalsVisibleTo Include="LanguageServiceProfiling" />
Expand Down
2 changes: 1 addition & 1 deletion vsintegration/tests/Salsa/FSharpLanguageServiceTestable.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ type internal FSharpLanguageServiceTestable() as this =
member this.Initialize (sp, dp, prefs, sourceFact) =
if this.Unhooked then raise Error.UseOfUnhookedLanguageServiceState
artifacts <- Some (ProjectSitesAndFiles())
let checker = FSharpChecker.Create(legacyReferenceResolver=FSharp.Compiler.MSBuildReferenceResolver.Resolver)
let checker = FSharpChecker.Create(useLegacyReferenceResolver=true)
checker.BeforeBackgroundFileCheck.Add (fun (filename,_) -> UIThread.Run(fun () -> this.NotifyFileTypeCheckStateIsDirty(filename)))
checkerContainerOpt <- Some (checker)
serviceProvider <- Some sp
Expand Down
2 changes: 1 addition & 1 deletion vsintegration/tests/UnitTests/TestLib.LanguageService.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ open Microsoft.VisualStudio.FSharp

[<AutoOpen>]
module internal Globals =
let checker = FSharpChecker.Create(legacyReferenceResolver=FSharp.Compiler.MSBuildReferenceResolver.Resolver)
let checker = FSharpChecker.Create(useLegacyReferenceResolver=true)


//open Internal.Utilities
Expand Down