Stack overflow fixes #7151
Merged
Stack overflow fixes #7151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TIHan
commented
Jul 6, 2019
Contributor
Author
|
Some tests are failing; there are IL gen issues happening. Will need to look at this more. |
dsyme
reviewed
Jul 8, 2019
dsyme
reviewed
Jul 8, 2019
dsyme
reviewed
Jul 8, 2019
…ctoring, created IlxMethodInfo type instead of using large tuples.
Contributor
Author
|
Getting close, but having some issues with when to evaluate delayed gen methods. |
Contributor
Author
|
Alright! We are passing now :) |
dsyme
requested changes
Jul 10, 2019
Contributor
dsyme
left a comment
dsyme
left a comment
There was a problem hiding this comment.
This is good, just one change requested
dsyme
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to solve this -> #7070
It adds some stress tests by trying to compile F# code that is very large.
Most of the reported stack overflows at this point are occurring at compile time when we generate IL. Looking at the Optimizer, it recursively goes through linear expression trees in a specific way that would create tail calls. In IlxGen, that wasn't happening for Expr.Sequential/Expr.Let. With this change, it should handle it. We also delay the generation of methods when evaluating expressions; this also prevents stack overflows.