Skip to content

Stack overflow fixes #7151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TIHan merged 28 commits into from
Jul 10, 2019
Merged

Stack overflow fixes #7151

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
8b96191
Trying to fix the stack overflow case in ilxgen
TIHan Jun 29, 2019
e12ce8a
Added stack guard to GenExpr
TIHan Jul 1, 2019
9815ca7
Still trying to resolve this
TIHan Jul 2, 2019
9556c93
This resolves the stack overflow, but need to review
TIHan Jul 3, 2019
f311bf8
Adding better tests
TIHan Jul 6, 2019
d4fb89b
Fixing compile and run successfully assert
TIHan Jul 6, 2019
4850159
One test passes
TIHan Jul 6, 2019
ddb073d
Fixing a few things
TIHan Jul 6, 2019
d8b0a56
Delete fieldNames.txt
TIHan Jul 6, 2019
122bb6c
Update IlxGen.fs
TIHan Jul 6, 2019
d25cadc
Update IlxGen.fs
TIHan Jul 6, 2019
869b0e9
Update IlxGen.fs
TIHan Jul 6, 2019
535bfeb
More work on CompilerAssert
TIHan Jul 7, 2019
f30073d
Got verifying IL working on method
TIHan Jul 7, 2019
74f575e
Always delay gen methods when already gen'ing in one. Some small refa…
TIHan Jul 8, 2019
20aec80
Better error message for stack overflow
TIHan Jul 8, 2019
6be6ac9
small msg change
TIHan Jul 8, 2019
02f9c04
Simplifying some tests
TIHan Jul 8, 2019
f2a0af8
Removing attempt at bringing a FSharpQA test to nunit
TIHan Jul 8, 2019
d14a37e
Fixing up seq points
TIHan Jul 8, 2019
5153803
More seq point tweaks
TIHan Jul 9, 2019
2ba7779
Trying to fix ilxgen
TIHan Jul 9, 2019
ad5814b
Fixing ilxgen
TIHan Jul 9, 2019
3dc23ca
Using RunScript
TIHan Jul 9, 2019
64af4e3
Fix test
TIHan Jul 9, 2019
75db610
removed IlxMethodInfo
TIHan Jul 10, 2019
b238394
trivial refactor
TIHan Jul 10, 2019
b3c36da
another quick refactor
TIHan Jul 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
@TIHan
TIHan committed Jul 9, 2019
commit 64af4e3a0c68ed8d4a77231129b48bc72921c792
2 changes: 1 addition & 1 deletion tests/fsharp/Compiler/CompilerAssert.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ module CompilerAssert =
""")

let args =
[|"--targetprofile:netcore"|]
defaultProjectOptions.OtherOptions
|> Array.append [| "fsc.exe"; inputFilePath; "-o:" + outputFilePath; (if isExe then "--target:exe" else "--target:library"); "--nowin32manifest" |]
let errors, _ = checker.Compile args |> Async.RunSynchronously

Expand Down