Skip to content

Conversation

@dotnet-maestro
Copy link

@dotnet-maestro dotnet-maestro bot commented Jul 14, 2021

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.WindowsDesktop.App.Ref: from 6.0.0-preview.7.21359.1 to 6.0.0-rc.1.21367.6 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0: from 6.0.0-preview.7.21359.1 to 6.0.0-rc.1.21367.6 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.NetCore.SharedFramework.x64.6.0: from 6.0.0-preview.7.21360.10 to 6.0.0-rc.1.21368.1 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Ref: from 6.0.0-preview.7.21360.10 to 6.0.0-rc.1.21368.1 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Runtime.win-x64: from 6.0.0-preview.7.21360.10 to 6.0.0-rc.1.21368.1 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Host.win-x64: from 6.0.0-preview.7.21360.10 to 6.0.0-rc.1.21368.1 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.DotNetHostResolver: from 6.0.0-preview.7.21360.10 to 6.0.0-rc.1.21368.1 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.Platforms: from 6.0.0-preview.7.21360.10 to 6.0.0-rc.1.21368.1 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Ref: from 6.0.0-preview.7.21363.16 to 6.0.0-rc.1.21366.3 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Ref.Internal: from 6.0.0-preview.7.21363.16 to 6.0.0-rc.1.21366.3 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Runtime.win-x64: from 6.0.0-preview.7.21363.16 to 6.0.0-rc.1.21366.3 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0: from 6.0.0-preview.7.21363.16 to 6.0.0-rc.1.21366.3 (parent: Microsoft.NET.Sdk)
    • dotnet-dev-certs: from 6.0.0-preview.7.21363.16 to 6.0.0-rc.1.21366.3 (parent: Microsoft.NET.Sdk)
    • dotnet-user-secrets: from 6.0.0-preview.7.21363.16 to 6.0.0-rc.1.21366.3 (parent: Microsoft.NET.Sdk)
    • Microsoft.DotNet.Common.ItemTemplates: from 6.0.100-preview.7.21363.4 to 6.0.100-rc.1.21366.2 (parent: Microsoft.NET.Sdk)
    • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 6.0.0-preview.7.21359.1 to 6.0.0-rc.1.21367.6 (parent: Microsoft.NET.Sdk)
    • Microsoft.Dotnet.WinForms.ProjectTemplates: from 6.0.0-preview.7.21328.3 to 6.0.0-rc.1.21366.1 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
    • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 6.0.0-preview.7.21359.1 to 6.0.0-rc.1.21367.6 (parent: Microsoft.NET.Sdk)
    • Microsoft.DotNet.Wpf.ProjectTemplates: from 6.0.0-preview.7.21351.3 to 6.0.0-rc.1.21367.4 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
    • Microsoft.FSharp.Compiler: from 12.0.0-beta.21362.4 to 12.0.0-beta.21366.4 (parent: Microsoft.NET.Sdk)
    • Microsoft.SourceBuild.Intermediate.fsharp: from 5.0.3-beta.21362.4 to 5.0.3-beta.21366.4 (parent: Microsoft.NET.Sdk)
    • Microsoft.NET.Test.Sdk: from 17.0.0-preview-20210712-03 to 17.0.0-preview-20210715-01 (parent: Microsoft.NET.Sdk)
    • Microsoft.NET.ILLink.Tasks: from 6.0.100-preview.6.21363.1 to 6.0.100-preview.6.21366.2 (parent: Microsoft.NET.Sdk)
    • Microsoft.Net.Compilers.Toolset: from 4.0.0-3.21363.4 to 4.0.0-3.21366.20 (parent: Microsoft.NET.Sdk)
    • Microsoft.Build: from 17.0.0-preview-21359-04 to 17.0.0-preview-21365-02 (parent: Microsoft.NET.Sdk)
    • NuGet.Build.Tasks: from 6.0.0-preview.2.129 to 6.0.0-preview.2.136 (parent: Microsoft.NET.Sdk)

From https://github.com/dotnet/sdk

  • Subscription: f5e16d6d-e643-4370-f3ed-08d8e97c775d
  • Build: 20210718.2
  • Date Produced: 7/18/2021 3:45 PM
  • Commit: 05ab6d2
  • Branch: refs/heads/main

dotnet-maestro bot added 6 commits July 14, 2021 09:47
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.7.21364.5

Dependency coherency updates

Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets
 From Version 6.0.0-preview.7.21363.16 -> To Version 6.0.0-preview.7.21363.17 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.7.21364.8

Dependency coherency updates

Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.Net.Compilers.Toolset
 From Version 6.0.0-preview.7.21363.16 -> To Version 6.0.0-preview.7.21363.17 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.7.21364.10

Dependency coherency updates

Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.Net.Compilers.Toolset
 From Version 6.0.0-preview.7.21363.16 -> To Version 6.0.0-preview.7.21363.17 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.7.21364.13

Dependency coherency updates

Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Net.Compilers.Toolset
 From Version 6.0.0-preview.7.21363.16 -> To Version 6.0.0-preview.7.21363.17 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.7.21364.14

Dependency coherency updates

Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.Net.Compilers.Toolset
 From Version 6.0.0-preview.7.21363.16 -> To Version 6.0.0-preview.7.21363.17 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.7.21364.15

Dependency coherency updates

Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.Net.Compilers.Toolset
 From Version 6.0.0-preview.7.21363.16 -> To Version 6.0.0-preview.7.21363.17 (parent: Microsoft.NET.Sdk
@lewing
Copy link
Member

lewing commented Jul 14, 2021

was the app template removed?

@lewing
Copy link
Member

lewing commented Jul 14, 2021

ahh #11111

@lewing
Copy link
Member

lewing commented Jul 14, 2021

cc @vlada-shubina

dotnet-maestro bot and others added 2 commits July 14, 2021 16:49
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.7.21364.16

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.Net.Compilers.Toolset
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-preview.7.21363.1 (parent: Microsoft.NET.Sdk
@vlada-shubina
Copy link
Member

pushed commit from #11111 over it, should pass now.

dotnet-maestro bot and others added 3 commits July 14, 2021 17:34
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.7.21364.17

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.Net.Compilers.Toolset
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-preview.7.21363.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.7.21364.20

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.Net.Compilers.Toolset
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-preview.7.21363.1 (parent: Microsoft.NET.Sdk
@lewing
Copy link
Member

lewing commented Jul 14, 2021

installer (build Linux Build_Linux_musl_Debug_x64) is failing with

Determining projects to restore...
  Restored /datadisks/disk1/workspace/_work/1/s/src/redist/targets/LayoutTool.csproj (in 666 ms).
  Determining projects to restore...
  Restored /datadisks/disk1/workspace/_work/1/s/src/redist/targets/DownloadPackage.csproj (in 6.6 sec).
/datadisks/disk1/workspace/_work/1/s/src/redist/targets/Crossgen.targets(118,5): error : Failed to load /datadisks/disk1/workspace/_work/1/s/.nuget/packages/microsoft.netcore.app.crossgen2.linux-musl-x64/6.0.0-preview.7.21363.9/tools/libcoreclr.so, error: Error relocating /datadisks/disk1/workspace/_work/1/s/.nuget/packages/microsoft.netcore.app.crossgen2.linux-musl-x64/6.0.0-preview.7.21363.9/tools/libcoreclr.so: memfd_create: symbol not found [/datadisks/disk1/workspace/_work/1/s/src/redist/redist.csproj]
##[error]src/redist/targets/Crossgen.targets(118,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Failed to load /datadisks/disk1/workspace/_work/1/s/.nuget/packages/microsoft.netcore.app.crossgen2.linux-musl-x64/6.0.0-preview.7.21363.9/tools/libcoreclr.so, error: Error relocating /datadisks/disk1/workspace/_work/1/s/.nuget/packages/microsoft.netcore.app.crossgen2.linux-musl-x64/6.0.0-preview.7.21363.9/tools/libcoreclr.so: memfd_create: symbol not found

which may be genuine

dotnet/runtime#55545 cc @janvorli

@janvorli
Copy link
Member

I've looked into it. The issue is that the CI leg uses Alpine 3.6 docker container. Alpine 3.6 has been out of support for at least two years. We build our stuff on 3.9 which has this newer function in its libc, but 3.6 didn't have it. And even 3.9 has been out of support for 6 months. In fact, support for 3.11 will end in 3 months.
The fix should be to switch the tests to alpine 3.13 docker image, which is the latest we have.

Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.7.21364.22

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.Net.Compilers.Toolset
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-preview.7.21363.1 (parent: Microsoft.NET.Sdk
@lewing
Copy link
Member

lewing commented Jul 14, 2021

cc @marcpopMSFT

dotnet-maestro bot and others added 4 commits July 14, 2021 22:06
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.7.21364.23

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.Net.Compilers.Toolset
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-preview.7.21363.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.7.21364.24

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.Net.Compilers.Toolset
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-preview.7.21363.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.7.21364.26

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.Net.Compilers.Toolset
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-preview.7.21363.1 (parent: Microsoft.NET.Sdk
@lewing
Copy link
Member

lewing commented Jul 15, 2021

installer (build Linux Build_Linux_musl_Debug_x64)

web -> /datadisks/disk1/workspace/work/1/s/artifacts/tmp/Debug/dotnetSdkTests/It_publishes---35C5D11A/bin/Release/netcoreapp2.0/web.dll\n No usable version of the libssl was found\n Aborted (core dumped)\n

@marcpopMSFT
Copy link
Member

@dotnet/domestic-cat For visibility. Disable that test on installer runs perhaps for now?

dotnet-maestro bot added 3 commits July 15, 2021 00:50
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.7.21364.29

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.Net.Compilers.Toolset
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-preview.7.21363.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.7.21364.31

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.Net.Compilers.Toolset
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-preview.7.21363.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.7.21364.32

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.Net.Compilers.Toolset
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-preview.7.21363.1 (parent: Microsoft.NET.Sdk
@jakubstilec
Copy link

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.7.21366.11

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-rc.1.21365.17 (parent: Microsoft.NET.Sdk
@sfoslund
Copy link
Member

I've made a PR into SDK to retarget this test: dotnet/sdk#18974

Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.1.21366.13

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-rc.1.21365.17 (parent: Microsoft.NET.Sdk
@dougbu
Copy link

dougbu commented Jul 16, 2021

Is there anything needed here other than merging dotnet/sdk#18974 then /azp run here❔ Wondering if you need help from dotnet/aspnetcore-land.

@ericstj
Copy link
Member

ericstj commented Jul 16, 2021

@JunTaoLuo your change dotnet/sdk@5dfe7e0 might have broken the VB template. I wonder if _IsNETCoreOrNETStandard is defined early enough? Shouldn't be the case since properties are defined before items.

dotnet-maestro bot added 2 commits July 16, 2021 21:43
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.1.21366.16

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-rc.1.21365.17 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.1.21366.18

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-rc.1.21365.17 (parent: Microsoft.NET.Sdk
@JunTaoLuo
Copy link

Hmm I am having trouble viewing the logs for the test failure since the builds restarted. I think the changes I have made are safe since MSBuild does two passes and ensures properties are defined before items, cc @dsplaisted. However, if you do suspect dotnet/sdk@5dfe7e0 to be an issue, feel free to revert.

One more note on the topic, one more change was made regarding the import items in https://github.com/dotnet/sdk/pull/18921/files. Looking over it again, I don't see how it could break things though. Again, I have to wait to see some test logs before being able to dig deeper into what's broken.

Again, feel free to revert anything if it would help to unblock this dependency update.

@JunTaoLuo
Copy link

JunTaoLuo commented Jul 16, 2021

Actually I think dotnet/sdk@9f43538 may have something to do with it. Ignore me, I just had a brain fart

dotnet-maestro bot added 4 commits July 16, 2021 23:30
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-preview.1.21366.20

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-rc.1.21365.17 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-rc.1.21366.21

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-rc.1.21365.17 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-rc.1.21366.23

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-rc.1.21365.17 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-rc.1.21366.25

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-rc.1.21365.17 (parent: Microsoft.NET.Sdk
@davidfowl
Copy link
Member

davidfowl commented Jul 17, 2021

Expected command to pass but it did not.\r\nFile Name: D:\workspace\_work\1\s\artifacts\bin\redist\Release\dotnet\dotnet.exe\r\nArguments: build        --framework net6.0-windows\r\nWorkingDir:: D:\workspace\_work\1\s\artifacts\bin\EndToEnd.Tests\Release\net6.0\Tests\EndToEnd.Tests\TestTemplateCreateAndBuildwinforms[VB]\r\nExit Code: 1\r\nStdOut:\r\nMicrosoft (R) Build Engine version 17.0.0-preview-21365-02+dfd2be739 for .NET\r\nCopyright (C) Microsoft Corporation. All rights reserved.\r\n\r\n  Determining projects to restore...\r\n  Restored D:\workspace\_work\1\s\artifacts\bin\EndToEnd.Tests\Release\net6.0\Tests\EndToEnd.Tests\TestTemplateCreateAndBuildwinforms[VB]\TestTemplateCreateAndBuildwinforms[VB].vbproj (in 71 ms).\r\n  You are using a preview version of .NET. See: https://aka.ms/dotnet-core-preview\r\nD:\workspace\_work\1\s\artifacts\bin\EndToEnd.Tests\Release\net6.0\Tests\EndToEnd.Tests\TestTemplateCreateAndBuildwinforms[VB]\Program.vb(4,6): error BC30002: Type 'STAThread' is not defined. [D:\workspace\_work\1\s\artifacts\bin\EndToEnd.Tests\Release\net6.0\Tests\EndToEnd.Tests\TestTemplateCreateAndBuildwinforms[VB]\TestTemplateCreateAndBuildwinforms[VB].vbproj]\r\n\r\nBuild FAILED.\r\n\r\nD:\workspace\_work\1\s\artifacts\bin\EndToEnd.Tests\Release\net6.0\Tests\EndToEnd.Tests\TestTemplateCreateAndBuildwinforms[VB]\Program.vb(4,6): error BC30002: Type 'STAThread' is not defined. [D:\workspace\_work\1\s\artifacts\bin\EndToEnd.Tests\Release\net6.0\Tests\EndToEnd.Tests\TestTemplateCreateAndBuildwinforms[VB]\TestTemplateCreateAndBuildwinforms[VB].vbproj]\r\n    0 Warning(s)\r\n    1 Error(s)\r\n\r\nTime Elapsed 00:00:00.51\r\nStdErr:\r\n\r\n

Winforms isn't fixed yet.

cc @KlausLoeffelmann @RussKie

@RussKie
Copy link

RussKie commented Jul 17, 2021

Our global usings support is blocked at WPF level.
dotnet/wpf#4779

@RussKie
Copy link

RussKie commented Jul 17, 2021

Oh, it is still the VB issue... I'll see if I can find what's going on on Monday.

dotnet-maestro bot added 2 commits July 17, 2021 14:13
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-rc.1.21367.2

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-rc.1.21365.17 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-rc.1.21367.3

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-rc.1.21365.17 (parent: Microsoft.NET.Sdk
@ericstj
Copy link
Member

ericstj commented Jul 17, 2021

I was able to get a local repro by pulling down artifacts from the CI build (couldn't get local build to give me a runnable layout). I confirmed my suspicion that it's the Imports. (note that System is missing)
image

But it wasn't @JunTaoLuo's change(s). It's actually caused by DisableImplicitNamespaceImports here: dotnet/wpf@ff1be8e#diff-681ca681001fbc20488df7fdbb46a8c40ac2df9dc2210df5ad869aee6a56df16R23
This disables these VB imports:
https://github.com/dotnet/sdk/blob/55195f3c4ba3f582aa91ec824bd24a7ba3e73528/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.DefaultItems.props#L118-L129

@ryalanms can we add a condition to this so that it either only applies when UseWPF is set or doesn't apply to VB? I'm not sure how WPF was broken that required this change to be made, I tried to undo it and was still able to build a default WPF C# app with dotnet CLI (maybe it's broken in VS or desktop msbuild???)

@ryalanms
Copy link
Member

ryalanms commented Jul 17, 2021

@ryalanms can we add a condition to this so that it either only applies when UseWPF is set or doesn't apply to VB? I'm not sure how WPF was broken that required this change to be made, I tried to undo it and was still able to build a default WPF C# app with dotnet CLI (maybe it's broken in VS or desktop msbuild???)

Yes, WPF wasn't able to build in VS with implicit namespace imports enabled.

To restate the problem, WinForms VB projects require implicit namespace imports to be enabled, but WPF has disabled them. The suggested fix is to scope disabling implicit namespace imports in WPF's WinFX targets to WPF-only or non-VB projects.

I wasn't able to reproduce this locally, but I did confirm that with the suggested fix, the property is no longer set when building WinForms VB projects:

dotnet/wpf#4868

The PR build in the SDK repo succeeded but was not auto-merged:

dotnet/sdk#19006

dotnet-maestro bot added 2 commits July 18, 2021 14:02
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-rc.1.21368.1

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-rc.1.21365.17 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk
 From Version 6.0.100-preview.7.21364.1 -> To Version 6.0.100-rc.1.21368.2

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.6.0,VS.Redist.Common.NetCore.SharedFramework.x64.6.0,Microsoft.NETCore.App.Ref,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.6.0,dotnet-dev-certs,dotnet-user-secrets,Microsoft.DotNet.Common.ItemTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.FSharp.Compiler,Microsoft.SourceBuild.Intermediate.fsharp,Microsoft.NET.Test.Sdk,Microsoft.NET.ILLink.Tasks,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 6.0.0-preview.7.21359.1 -> To Version 6.0.0-rc.1.21367.6 (parent: Microsoft.NET.Sdk
@dsplaisted dsplaisted enabled auto-merge July 18, 2021 17:12
@lewing
Copy link
Member

lewing commented Jul 18, 2021

Looks green now. Hit upload failure on one leg that I've restarted.

@dsplaisted dsplaisted merged commit a588951 into main Jul 18, 2021
@dotnet-maestro dotnet-maestro bot deleted the darc-main-de4a6923-e884-4443-ac6c-0519cbd2e4f2 branch July 18, 2021 17:36
@dsplaisted
Copy link
Member

It merged! Thanks for everyone who helped figure this out. @ericstj @JunTaoLuo @RussKie @ryalanms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.