Skip to content

Rationalize default Imports for C# and VB #18921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsplaisted merged 2 commits into from
Jul 15, 2021
Merged

Rationalize default Imports for C# and VB #18921

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90a5cc4
Rationalize default Imports for C# and VB
dsplaisted Jul 14, 2021
9f43538
Fix ordering of Import items to be alphabetical
dsplaisted Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.DefaultItems.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,18 +82,20 @@ Copyright (c) .NET Foundation. All rights reserved.

</ItemGroup>

<!-- C# implicit imports -->
<!-- Implicit imports -->
<ItemGroup Condition=" '$(DisableImplicitNamespaceImports_DotNet)' != 'true'
and '$(Language)' == 'C#'
and '$(TargetFrameworkIdentifier)' == '.NETCoreApp'
and $([MSBuild]::VersionGreaterThanOrEquals($(_TargetFrameworkVersionWithoutV), '6.0'))">
<Import Include="System" />
<Import Include="System.Collections.Generic" />

<!-- Imports already defined as VB implicit imports are conditioned to not be added twice -->
<Import Include="System" Condition="'$(Language)' != 'VB'" />
<Import Include="System.Collections.Generic" Condition="'$(Language)' != 'VB'" />
<Import Include="System.IO" />
Copy link
Contributor

@JunTaoLuo JunTaoLuo Jul 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit.

It would be nice to sort the Import items when generating the file now that we organize them logically. We used to preserve the alphabetical order as a side effect of how they are organized but it will no longer be the case after this change. I know it's rare for users to browse to this file, but the fact that it's a visible .cs file for C# projects in the obj directory makes me want to strive for more clean looking file.

<Import Include="System.Linq" />
<Import Include="System.Linq" Condition="'$(Language)' != 'VB'" />
<Import Include="System.Net.Http" />
<Import Include="System.Threading" />
<Import Include="System.Threading.Tasks" />
<Import Include="System.Threading.Tasks" Condition="'$(Language)' != 'VB'" />

</ItemGroup>

<!-- VB implicit imports -->
Expand Down